Skip to content

i18n(ja): use one rendering for compaction in the release notes (part 2) - #24258

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-compaction-term-part2
Oct 10, 2026
Merged

qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-compaction-term-part2

Conversation

@yahonda

@yahonda yahonda commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Renders "compaction" (RocksDB, TiKV, TiFlash, and log backup compaction) as コンパクション instead of 圧縮 in the release notes. This is part 2 of the change in #24200, which covered the reference docs. 圧縮 is the established Japanese word for "compression", so using it for compaction made release notes such as 「圧縮率を自動的に調整」 (EN "adjusts the compaction rate") read as if they were about data compression.

This PR changes 92 lines in 48 files.

How each site was chosen

  • Each of the 170 lines with 圧縮 in releases/ was matched with its EN line on release-8.5.
  • If the EN line says compaction, compact, or compacted, the site was changed.
  • If it says compress or compression, it was kept.
  • 24 lines could not be matched automatically. Each was checked by hand against EN: 18 are compaction and 6 are compression.

Wording changes beyond the plain replacement

  • releases/release-5.0.0-rc.md: 「圧縮率」 (EN "compaction rate", meaning speed) → 「コンパクション速度」. A plain replacement would be 「コンパクション率」, which reads like "compression ratio". The same feature's heading in release-5.0.0.md uses 「データコンパクション速度」.
  • releases/release-8.5.5.md: 「圧縮ログバックアップ」 (EN "compacted log backups") → 「コンパクションされたログバックアップ」.

Kept as 圧縮 because EN says "compress" or "compression" (78 lines)

These include gRPC message compression, Dumpling and TiDB Lightning compression formats, zstd and lz4, TiFlash dt_compression_*, redo log compression, the MySQL compression protocol, and UNCOMPRESS(). The release-5.0.0.md heading 「TiFlashは、圧縮とデータソートにおけるI/Oリソースの使用を制限します」 is also kept, because EN says "compression and data sorting".

Configuration names, anchors, and code are unchanged.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated Japanese release-note terminology across TiDB, TiKV, TiFlash, and Lightning to consistently describe data compaction, rather than compression.
    • Clarified references to compaction behavior, settings, metrics, and issue fixes; the documented functionality and configuration values remain unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Oct 9, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingcap/docs/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0a9c619f-b8e8-4d2b-b0b7-8ff5128d1700
📥 Commits

Reviewing files that changed from the base of the PR and between c070372 and 0c742a6.

📒 Files selected for processing (48)
  • releases/release-1.0-ga.md
  • releases/release-2.0-ga.md
  • releases/release-2.0-rc.3.md
  • releases/release-2.1-ga.md
  • releases/release-2.1-rc.1.md
  • releases/release-2.1.4.md
  • releases/release-3.0.0-beta.1.md
  • releases/release-3.0.5.md
  • releases/release-4.0.0-beta.md
  • releases/release-4.0.11.md
  • releases/release-4.0.5.md
  • releases/release-5.0.0-rc.md
  • releases/release-5.0.0.md
  • releases/release-5.0.2.md
  • releases/release-5.1.0.md
  • releases/release-5.1.3.md
  • releases/release-5.2.0.md
  • releases/release-5.2.3.md
  • releases/release-5.2.4.md
  • releases/release-5.3.0.md
  • releases/release-5.3.1.md
  • releases/release-5.4.0.md
  • releases/release-6.1.0.md
  • releases/release-6.1.3.md
  • releases/release-6.2.0.md
  • releases/release-6.4.0.md
  • releases/release-6.5.0.md
  • releases/release-6.5.11.md
  • releases/release-6.5.4.md
  • releases/release-7.1.0.md
  • releases/release-7.1.2.md
  • releases/release-7.1.6.md
  • releases/release-7.2.0.md
  • releases/release-7.3.0.md
  • releases/release-7.4.0.md
  • releases/release-7.5.0.md
  • releases/release-7.5.4.md
  • releases/release-7.5.7.md
  • releases/release-7.6.0.md
  • releases/release-8.0.0.md
  • releases/release-8.1.2.md
  • releases/release-8.2.0.md
  • releases/release-8.4.0.md
  • releases/release-8.5.3.md
  • releases/release-8.5.4.md
  • releases/release-8.5.5.md
  • releases/release-8.5.6.md
  • releases/release-8.5.7.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Release notes across TiDB versions replace compression terminology with compaction terminology in Japanese descriptions. The edits preserve the documented settings, conditions, and behavior.

Changes

Compaction terminology updates

Layer / File(s) Summary
Early release notes
releases/release-1.*, releases/release-2.*, releases/release-3.*, releases/release-4.*, releases/release-5.*
Entries in releases 1.0–5.4 use compaction terminology in place of compression terminology for TiKV, TiFlash, and Lightning.
Release notes for versions 6.x–7.4
releases/release-6.*, releases/release-7.1*, releases/release-7.2*, releases/release-7.3*, releases/release-7.4*
TiFlash feature descriptions, TiKV settings, and improvement entries use compaction terminology.
Release notes for versions 7.5–8.5
releases/release-7.5*, releases/release-7.6*, releases/release-8.*
TiKV settings and release entries use compaction terminology for compaction behavior.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: qiancai

Merge Risk: ⚪ Minimal · up to 0c742

This PR updates Japanese release-note terminology without changing product behavior. No concrete user-facing or operational regression is supported, so it appears ready to merge after normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 0c742

The change affects 1 system.

Changed systems: releases

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — releases (service) was modified; 48 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in releases/release-1.0-ga.md: The TiKV entry changes the operation described as manually triggered for quickly freeing space from data compression to data compaction.
  • observed — Modified behavior in releases/release-2.0-ga.md: TiKV の安定性に関する項目で、リージョンサイズ情報を随時更新する契機を圧縮イベントからコンパクションイベントに変更しました。
  • observed — Modified behavior in releases/release-2.0-rc.3.md: TiKVの項目で、リージョンサイズ情報の更新を圧縮イベントに応じて行う記述を、コンパクションイベントに応じて行う記述に変更しました。
  • observed — Modified behavior in releases/release-2.1-ga.md: compact コマンドが最下層のデータを圧縮するかどうかを指定できるという説明を、「圧縮」から「コンパクション」に変更しました。
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description clearly explains the terminology changes, scope, selection method, exceptions, affected branch, related PR, AI involvement, and unchanged configuration details. It covers the required …
Title check Passed The title clearly identifies the Japanese localization change for compaction terminology in the release notes and indicates that this is part 2.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 10, 2026

@qiancai qiancai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 10, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-10-10 02:54:58.251969909 +0000 UTC m=+440507.999200758: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit 983908e into pingcap:i18n-ja-release-8.5 Oct 10, 2026
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants