i18n(ja): fix 14 more adjacent-bold-span defects across 13 files - #23549
Conversation
Continuation of the adjacent-bold-span defect sweep (see pingcap#23547/pingcap#23548 for the earlier two clusters). Each of these is a EN sentence with two distinct **bold** terms joined by a connector word (and/or/as/to/etc.) where JA had trapped that connector word (particle or conjunction) inside the closing/opening ** markers instead of leaving it as plain text between the two spans: - tidb-troubleshooting-map.md: Grafana breadcrumb (-> TiDB and TiKV) - auto-increment.md: unique and monotonically increasing - dev-guide-gui-mysql-workbench.md: SQL Editor > MySQL Session - dev-guide-create-table.md (x2): primary key/clustered index, columns/primary keys - dev-guide-sample-application-nodejs-prisma.md: recommend phrasing - dev-guide-sample-application-nodejs-mysql2.md + nodejs-mysqljs.md: MUST-enable phrasing (also matches the established corpus convention of bolding 必要があります as one unit) - dev-guide-sample-application-ruby-mysql2.md: same MUST phrasing plus a trailing but/が particle - ticdc-summary-monitor.md: Sink flush rows/s vs Puller output events/s - tidb-cloud/backup-and-restore.md: date and time selection (kept as a single natural 日時 term per corpus convention, particle moved outside) - tidb-cloud/integrate-tidbcloud-with-airbyte.md: reconstructed the Set up source/destination sentence into two clean quoted spans - tiflash/tiflash-disaggregated-and-s3.md: disaggregated vs coupled architecture - dashboard/dashboard-session-sso.md: reconstructed the Auth0 Client ID sentence to match this file's own established convention (OIDC クライアント ID kept as katakana, not English, unlike the TiDB Cloud console UI-label campaign) Explicitly skipped (already fixed by sibling PR pingcap#23535, still open — verified via `git show origin/<branch>:<file>` before starting): tidb-cloud/dedicated-external-storage.md (Storage Provider/Amazon S3) and tidb-cloud/data-service-get-started.md (+ Create Endpoint).
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
User feedback: bolding only the kanji stem 勧め inside the honorific verb お勧めします (お**勧め**します) reads as unnatural mid-word emphasis in Japanese. Bold the whole polite verb phrase instead (**お勧めします**), matching how a single EN emphasis word (RECOMMENDED) should map to one coherent JA unit rather than splitting the honorific prefix/stem/ending across bold boundaries. Fixes both occurrences of this pattern in the corpus: the one just introduced in this PR (nodejs-prisma.md) and one pre-existing sibling instance found via corpus grep (nodejs-typeorm.md, same EN sentence, same defect, not otherwise touched by this PR).
[LGTM Timeline notifier]Timeline:
|
Summary
Continuation of the adjacent-bold-span defect sweep (see #23547/#23548 for the earlier two large clusters). Each of these is an EN sentence with two distinct bold terms joined by a connector word (and/or/as/to/etc.) where JA had trapped that connector word (a particle or conjunction) inside the closing/opening
**markers instead of leaving it as plain text between the two spans.Files fixed (1 line each unless noted):
tidb-troubleshooting-map.md— Grafana breadcrumb (Grafana -> **TiDB** and **TiKV**)auto-increment.md— unique and monotonically increasingdevelop/dev-guide-gui-mysql-workbench.md— SQL Editor > MySQL Sessiondevelop/dev-guide-create-table.md(2 lines) — primary key/clustered index, columns/primary keysdevelop/dev-guide-sample-application-nodejs-prisma.md— "recommend" phrasingdevelop/dev-guide-sample-application-nodejs-mysql2.md+nodejs-mysqljs.md— MUST-enable phrasing (also now matches the established corpus convention of bolding 必要があります as one unit)develop/dev-guide-sample-application-ruby-mysql2.md— same MUST phrasing plus a trailing but/が particleticdc/ticdc-summary-monitor.md— Sink flush rows/s vs Puller output events/stidb-cloud/backup-and-restore.md— date and time selection (kept as a single natural 日時 term per corpus convention, particle moved outside)tidb-cloud/integrate-tidbcloud-with-airbyte.md— reconstructed the "Set up source/destination" sentence into two clean quoted spanstiflash/tiflash-disaggregated-and-s3.md— disaggregated vs coupled architecturedashboard/dashboard-session-sso.md— reconstructed the Auth0 Client ID sentence to match this file's own established convention (OIDC クライアント ID kept as katakana, NOT English, unlike the TiDB Cloud console UI-label campaign — verified against 3 other occurrences in the same file before assuming English was correct)Explicitly skipped (already fixed by sibling PR #23535, still open — verified via
git show origin/<branch>:<file>before starting, to avoid duplicate/conflicting work):tidb-cloud/dedicated-external-storage.md(Storage Provider/Amazon S3) andtidb-cloud/data-service-get-started.md(+ Create Endpoint).Side finding, not fixed here: while checking for conflicts, found that 5 other open PRs (#23535, #23543, #23545, #23547, #23548 — including my own #23547/#23548) are now stale against the current upstream tip (several sibling PRs merged since they were branched) and will need a rebase before they can merge cleanly. Flagging for whoever sequences the merge order; out of scope for this small fix.
Test plan
**-parity issues in the diff (automated check)git merge-treethat none of these 14 lines participate in any conflict with the 5 sibling branches checked