v8.5.7: support logging session connect attrs to slow query log (#22547)#22775
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
do-not-merge/hold
|
@jiong-nba This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
Bot
added
size/L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces documentation for logging session connection attributes to the slow query log, including new system and status variables such as performance_schema_session_connect_attrs_size. Critical issues were identified where Git conflict markers were left in the SLOW_QUERY and CLUSTER_SLOW_QUERY table schemas, which must be resolved. Additionally, several sections require updates to use active voice and the second person to comply with the documentation style guide.
| The output is as follows: | ||
|
|
||
| ```sql | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
This file contains Git conflict markers (e.g., <<<<<<< HEAD, =======, >>>>>>>) inside the SQL code blocks. These markers indicate a failed merge or cherry-pick and must be resolved before the documentation can be published. Please remove the markers and the redundant old table schema, keeping only the updated version.
References
- Technical accuracy and completeness are essential for documentation quality. (link)
| The output is as follows: | ||
|
|
||
| ```sql | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Similar to the SLOW_QUERY table above, the CLUSTER_SLOW_QUERY section also contains Git conflict markers that need to be resolved. Ensure that only the correct, updated table schema is displayed in the final output.
ti-chi-bot
Bot
added
size/XL
ti-chi-bot
Bot
added
size/M
hfxsd
changed the title
hfxsd
added
the
needs-cherry-pick-master
lilin90
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lilin90
removed
the
do-not-merge/hold
ti-chi-bot
Bot
merged commit 68bb5e6
into
pingcap:feature/preview-v8.5.7
|
In response to a cherrypick label: new pull request created to branch |
5 participants
This is an automated cherry-pick of #22547
First-time contributors' checklist
What is changed, added or deleted? (Required)
This PR updates docs according to pingcap/tidb#66617:
Session_connect_attrs(json) to the schema examples ofINFORMATION_SCHEMA.SLOW_QUERYandINFORMATION_SCHEMA.CLUSTER_SLOW_QUERY.performance_schema_session_connect_attrs_size(default/range/-1behavior/truncation/1 MiB hard limit note).Performance_schema_session_connect_attrs_longest_seenPerformance_schema_session_connect_attrs_lostSESSION_CONNECT_ATTRSdoc with size limit and truncation behavior.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?