fix a link in release-8.5.5.md by qiancai · Pull Request #22422 · pingcap/docs

qiancai · 2026-02-07T12:58:03Z

First-time contributors' checklist

I've signed the Contributor License Agreement, which is required for the repository owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

gemini-code-assist · 2026-02-07T12:58:15Z

Summary of Changes

Hello @qiancai, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor documentation error by fixing a broken hyperlink within the release-8.5.5.md file. The change ensures that users can correctly navigate to the documentation for a specific optimizer hint, thereby improving the overall accuracy and usability of the release notes.

Highlights

Documentation Fix: Corrected a broken link in the release-8.5.5.md file. The URL for the NO_INDEX_LOOKUP_PUSHDOWN optimizer hint previously contained an erroneous double hyphen, which has been updated to a single hyphen to ensure the link functions correctly.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

releases/release-8.5.5.md
- Fixed a broken URL for the NO_INDEX_LOOKUP_PUSHDOWN optimizer hint by correcting a hyphenation error in the link.

Activity

No specific activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request fixes a typo in a link within the release notes. While the change correctly removes an extra dash, the link's anchor appears to be incomplete. I've suggested a further correction to ensure the link points to the correct section in the documentation. It seems other similar links in this file might have the same issue and could be fixed as well.

releases/release-8.5.5.md

ti-chi-bot · 2026-02-09T01:52:33Z

[LGTM Timeline notifier]

Timeline:

2026-02-09 01:52:33.004548948 +0000 UTC m=+149768.698688798: ☑️ agreed by hfxsd.

releases/release-8.5.5.md

hfxsd · 2026-02-09T02:02:31Z

releases/release-8.5.5.md

    Starting from v8.5.5, TiDB supports using [optimizer hints](/optimizer-hints.md) to push the `IndexLookUp` operator down to TiKV nodes. This reduces the number of remote procedure calls (RPCs) and can improve query performance. The actual performance improvement varies depending on the specific workload and requires testing for verification.

-    To explicitly instruct the optimizer to push index lookups down to TiKV for a specific table, you can use the [`INDEX_LOOKUP_PUSHDOWN(t1_name, idx1_name [, idx2_name ...])`](https://docs.pingcap.com/tidb/v8.5/optimizer-hints#index_lookup_pushdownt1_name-idx1_name--idx2_name--new-in-v855) hint. It is recommended to combine this hint with the table's AFFINITY attribute. For example, set `AFFINITY="table"` for regular tables and `AFFINITY="partition"` for partitioned tables.
+    To explicitly instruct the optimizer to push index lookups down to TiKV for a specific table, you can use the [`INDEX_LOOKUP_PUSHDOWN(t1_name, idx1_name [, idx2_name ...])`](https://docs.pingcap.com/tidb/v8.5/optimizer-hints#index_lookup_pushdownt1_name-idx1_name--idx2_name-new-in-v855) hint. It is recommended to combine this hint with the table's AFFINITY attribute. For example, set `AFFINITY="table"` for regular tables and `AFFINITY="partition"` for partitioned tables.


Suggested change

To explicitly instruct the optimizer to push index lookups down to TiKV for a specific table, you can use the [`INDEX_LOOKUP_PUSHDOWN(t1_name, idx1_name [, idx2_name ...])`](https://docs.pingcap.com/tidb/v8.5/optimizer-hints#index_lookup_pushdownt1_name-idx1_name--idx2_name-new-in-v855) hint. It is recommended to combine this hint with the table's AFFINITY attribute. For example, set `AFFINITY="table"` for regular tables and `AFFINITY="partition"` for partitioned tables.

To explicitly instruct the optimizer to push index lookups down to TiKV for a specific table, you can use the [`INDEX_LOOKUP_PUSHDOWN(t1_name, idx1_name [, idx2_name ...])`](https://docs.pingcap.com/tidb/v8.5/optimizer-hints#index_lookup_pushdownt1_name-idx1_name--idx2_name--new-in-v855) hint. It is recommended to combine this hint with the table's AFFINITY attribute. For example, set `AFFINITY="table"` for regular tables and `AFFINITY="partition"` for partitioned tables.

This change is not needed, as https://docs.pingcap.com/tidb/v8.5/optimizer-hints#index_lookup_pushdownt1_name-idx1_name--idx2_name-new-in-v855 works in the web browser.

qiancai · 2026-02-09T02:05:38Z

/approve

ti-chi-bot · 2026-02-09T02:05:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [qiancai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-02-09T02:05:51Z

@qiancai: You cannot manually add or delete the cherry pick approval state labels, only I and the tursted members have permission to do so. You can approve it in internal platform.

Details

In response to removing label named approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2026-02-09T02:11:38Z

In response to a cherrypick label: new pull request created to branch release-8.5: #22424.

Update release-8.5.5.md

739fa8d

ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Feb 7, 2026

qiancai self-assigned this Feb 7, 2026

ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2026

gemini-code-assist bot reviewed Feb 7, 2026

View reviewed changes

releases/release-8.5.5.md Show resolved Hide resolved

qiancai added the translation/no-need No need to translate this PR. label Feb 9, 2026

ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Feb 9, 2026

hfxsd approved these changes Feb 9, 2026

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 9, 2026

hfxsd reviewed Feb 9, 2026

View reviewed changes

releases/release-8.5.5.md Show resolved Hide resolved

hfxsd reviewed Feb 9, 2026

View reviewed changes

releases/release-8.5.5.md Show resolved Hide resolved

hfxsd reviewed Feb 9, 2026

View reviewed changes

qiancai force-pushed the 8.5.5-fix-a-link branch from a54e926 to 739fa8d Compare February 9, 2026 02:02

qiancai added the lgtm label Feb 9, 2026

ti-chi-bot bot added the approved label Feb 9, 2026

qiancai added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed approved labels Feb 9, 2026

ti-chi-bot bot added the approved label Feb 9, 2026

ti-chi-bot bot merged commit fc34824 into pingcap:master Feb 9, 2026
14 checks passed

ti-chi-bot mentioned this pull request Feb 9, 2026

fix a link in release-8.5.5.md (#22422) #22424

Open

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix a link in release-8.5.5.md#22422

fix a link in release-8.5.5.md#22422
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
qiancai:8.5.5-fix-a-link

qiancai commented Feb 7, 2026

Uh oh!

gemini-code-assist bot commented Feb 7, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

ti-chi-bot bot commented Feb 9, 2026

Uh oh!

Uh oh!

Uh oh!

hfxsd Feb 9, 2026

Uh oh!

qiancai Feb 9, 2026

Uh oh!

qiancai commented Feb 9, 2026

Uh oh!

ti-chi-bot bot commented Feb 9, 2026

Uh oh!

ti-chi-bot bot commented Feb 9, 2026

Uh oh!

Uh oh!

ti-chi-bot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

qiancai commented Feb 7, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

gemini-code-assist bot commented Feb 7, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

ti-chi-bot bot commented Feb 9, 2026

[LGTM Timeline notifier]

Uh oh!

Uh oh!

Uh oh!

hfxsd Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

qiancai Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

qiancai commented Feb 9, 2026

Uh oh!

ti-chi-bot bot commented Feb 9, 2026

Uh oh!

ti-chi-bot bot commented Feb 9, 2026

Uh oh!

Uh oh!

ti-chi-bot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants