Skip to content

tikv: add max-ts configuration docs for v8.5.7#21745

Open
ekexium wants to merge 2 commits into
pingcap:release-8.5from
ekexium:avery/max-ts-config-doc-8.5
Open

tikv: add max-ts configuration docs for v8.5.7#21745
ekexium wants to merge 2 commits into
pingcap:release-8.5from
ekexium:avery/max-ts-config-doc-8.5

Conversation

@ekexium

@ekexium ekexium commented Jun 25, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Document the TiKV storage.max-ts configuration section for v8.5.7 on the release-8.5 branch, including:

  • action-on-invalid-update
  • cache-sync-interval
  • max-drift

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Configuration changes
  • API changes
  • SQL syntax changes
  • Error code changes
  • Others

Signed-off-by: Ziqian Qin <eke@fastmail.com>
Copilot AI review requested due to automatic review settings June 25, 2026 06:53
@ti-chi-bot

ti-chi-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign queenypingcap for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2026
Signed-off-by: Ziqian Qin <eke@fastmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the TiKV configuration documentation to cover the new storage.max-ts configuration section introduced for the TiDB v8.5 (release-8.5) line, specifically targeting v8.5.7.

Changes:

  • Added a new ## storage.max-ts section describing what max-ts is and why it matters for Async Commit / 1PC correctness.
  • Documented the new storage.max-ts options: action-on-invalid-update, cache-sync-interval, and max-drift.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +663 to +664
+ 默认值:`"60s"`
+ 建议设置为 [`cache-sync-interval`](#cache-sync-interval-从-v857-版本开始引入) 的 3 倍以上。
@ekexium ekexium requested a review from qiancai June 25, 2026 07:48
@qiancai qiancai self-assigned this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants