Make journal concurrency regressions portable across Python versions - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Journal concurrency regressions depended on two incidental properties of the test environment: Python 3.14's
Path.exists()implementation and completion of a filesystem operation within 200 ms. Hosted Python 3.12/3.13 jobs exposed those assumptions.Only tests and their comments change. Runtime, C++ engine, licensing and trading behavior are unchanged.
Validation: all 59 journal/contention tests pass locally on Python 3.12, 3.13 and 3.14. Independent exact-head Grok review completed before pushing each correction. The full GitHub CI matrix must pass before merge.