Skip to content

Make journal concurrency regressions portable across Python versions - #1

Merged
luisleo526 merged 2 commits into
mainfrom
fix/portable-stop-race-test
Sep 9, 2026
Merged

Make journal concurrency regressions portable across Python versions#1
luisleo526 merged 2 commits into
mainfrom
fix/portable-stop-race-test

Conversation

@luisleo526

@luisleo526 luisleo526 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Journal concurrency regressions depended on two incidental properties of the test environment: Python 3.14's Path.exists() implementation and completion of a filesystem operation within 200 ms. Hosted Python 3.12/3.13 jobs exposed those assumptions.

  • Inject the STOP-padding race at the append-open boundary, after the stale size is captured. Assert one injected race, append-only padding, and preservation of the STOP payload.
  • Require the no-flock control child to complete successfully while the parent still holds its lock. Keep the 15-second subprocess timeout and real positive contention test; remove the machine-speed threshold.

Only tests and their comments change. Runtime, C++ engine, licensing and trading behavior are unchanged.

Validation: all 59 journal/contention tests pass locally on Python 3.12, 3.13 and 3.14. Independent exact-head Grok review completed before pushing each correction. The full GitHub CI matrix must pass before merge.

@luisleo526 luisleo526 changed the title Make STOP-marker race regression portable across Python versions Make journal concurrency regressions portable across Python versions Sep 9, 2026
@luisleo526
luisleo526 merged commit 9d76f8c into main Sep 9, 2026
12 checks passed
@luisleo526
luisleo526 deleted the fix/portable-stop-race-test branch September 9, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant