Skip to content

[Task] Fix PHPStan issues #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcPimcore merged 1 commit into from
Apr 1, 2026
+10 −10
Merged

[Task] Fix PHPStan issues #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Lib/DocumentResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

use Exception;
use Pimcore\Document;
use Pimcore\Document\Adapter;
use Pimcore\Document\AdapterInterface;

/**
* @internal
Expand All @@ -25,7 +25,7 @@ final class DocumentResolver implements DocumentResolverInterface
/**
* @throws Exception
*/
public function getInstance(?string $adapter = null): ?Adapter
public function getInstance(?string $adapter = null): ?AdapterInterface
{
return Document::getInstance($adapter);
}
Expand All @@ -40,7 +40,7 @@ public function isFileTypeSupported(string $filetype): bool
return Document::isFileTypeSupported($filetype);
}

public function getDefaultAdapter(): ?Adapter
public function getDefaultAdapter(): ?AdapterInterface
{
return Document::getDefaultAdapter();
}
Expand Down
6 changes: 3 additions & 3 deletions src/Lib/DocumentResolverInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace Pimcore\Bundle\StaticResolverBundle\Lib;

use Exception;
use Pimcore\Document\Adapter;
use Pimcore\Document\AdapterInterface;

/**
* @internal
Expand All @@ -24,11 +24,11 @@ interface DocumentResolverInterface
/**
* @throws Exception
*/
public function getInstance(?string $adapter = null): ?Adapter;
public function getInstance(?string $adapter = null): ?AdapterInterface;

public function isAvailable(): bool;

public function isFileTypeSupported(string $filetype): bool;

public function getDefaultAdapter(): ?Adapter;
public function getDefaultAdapter(): ?AdapterInterface;
}
4 changes: 2 additions & 2 deletions src/Lib/VideoResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

use Exception;
use Pimcore\Video;
use Pimcore\Video\Adapter;
use Pimcore\Video\AdapterInterface;

/**
* @internal
Expand All @@ -25,7 +25,7 @@ final class VideoResolver implements VideoResolverInterface
/**
* @throws Exception
*/
public function getInstance(): ?Adapter
public function getInstance(): ?AdapterInterface
{
return Video::getInstance();
}
Expand Down
4 changes: 2 additions & 2 deletions src/Lib/VideoResolverInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace Pimcore\Bundle\StaticResolverBundle\Lib;

use Exception;
use Pimcore\Video\Adapter;
use Pimcore\Video\AdapterInterface;

/**
* @internal
Expand All @@ -24,7 +24,7 @@ interface VideoResolverInterface
/**
* @throws Exception
*/
public function getInstance(): ?Adapter;
public function getInstance(): ?AdapterInterface;

public function isAvailable(): bool;
}
Loading