Skip to content

fix: remove no-op deadline methods from streamAdapter (PILOT-79) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-pilot wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −16
Open

fix: remove no-op deadline methods from streamAdapter (PILOT-79) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ require (
github.com/pilot-protocol/trustedagents v0.1.0 // indirect
)

replace github.com/TeoSlayer/pilotprotocol => ../web4
replace github.com/TeoSlayer/pilotprotocol => /home/node/.openclaw/workspace/repos/web4
5 changes: 1 addition & 4 deletions streams.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ package runtime
import (
"context"
"errors"
"time"

"github.com/TeoSlayer/pilotprotocol/pkg/coreapi"
"github.com/TeoSlayer/pilotprotocol/pkg/daemon"
Expand Down Expand Up @@ -78,9 +77,7 @@ func (s *streamAdapter) LocalPort() uint16 { return s.conn.LocalPort }
func (s *streamAdapter) RemoteAddr() coreapi.Addr { return s.conn.RemoteAddr }
func (s *streamAdapter) RemotePort() uint16 { return s.conn.RemotePort }

func (s *streamAdapter) SetDeadline(time.Time) error { return nil }
func (s *streamAdapter) SetReadDeadline(time.Time) error { return nil }
func (s *streamAdapter) SetWriteDeadline(time.Time) error { return nil }


var (
_ coreapi.Streams = daemonStreams{}
Expand Down
14 changes: 3 additions & 11 deletions zz_streams_ceiling_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"net"
"strings"
"testing"
"time"

"github.com/TeoSlayer/pilotprotocol/pkg/coreapi"
"github.com/TeoSlayer/pilotprotocol/pkg/daemon"
Expand Down Expand Up @@ -155,16 +154,9 @@ func TestDaemonListener_AcceptDeliversStreamWithAccessors(t *testing.T) {
t.Errorf("RemotePort = %d, want 8888", got)
}

// The deadline shims are documented no-ops returning nil.
if err := stream.SetDeadline(time.Now().Add(time.Hour)); err != nil {
t.Errorf("SetDeadline: %v", err)
}
if err := stream.SetReadDeadline(time.Now().Add(time.Hour)); err != nil {
t.Errorf("SetReadDeadline: %v", err)
}
if err := stream.SetWriteDeadline(time.Now().Add(time.Hour)); err != nil {
t.Errorf("SetWriteDeadline: %v", err)
}
// Deadline methods were removed from coreapi.Stream (PILOT-79).
// The runtime cannot honor them; removing from the interface
// gives callers a compile-time signal instead of a silent no-op.

// Closing the stream goes through daemon.CloseConnection, which for
// a synthetic conn in StateClosed exits via the non-ESTABLISHED
Expand Down
Loading