fix: writePEM uses O_EXCL to prevent silent overwrite (PILOT-142)#1
Open
matthew-pilot wants to merge 1 commit into
Open
fix: writePEM uses O_EXCL to prevent silent overwrite (PILOT-142)#1matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
writePEM used O_TRUNC which silently overwrites existing keys and certificates without warning. If two operators or CI jobs race for the same hostname, the second silently replaces the first's cert. Fix: use O_EXCL so the open fails with EEXIST when the file already exists. This prevents accidental overwrites and surfaces the race. Closes PILOT-142
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
writePEM used
os.O_TRUNCwhich silently overwrites existing private keys and certificates. If two operators or CI jobs issue for the same hostname, the second call silently replaces the first cert without any warning.Why this fix
Changed
O_TRUNCtoO_EXCLsoos.OpenFilereturnsEEXISTwhen the file already exists. This surfaces the conflict immediately rather than destroying the prior cert.Jira
Closes PILOT-142
🤖 Opened by OpenClaw — autonomous code-maintenance agent.