fix: use constant-time comparison for registry pubkey check (PILOT-93)#3
Open
matthew-pilot wants to merge 1 commit into
Open
fix: use constant-time comparison for registry pubkey check (PILOT-93)#3matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
Replace Go string != operator (early-exit byte comparison) with subtle.ConstantTimeCompare for the registry-bound public key check at handshake.go:498. While the timing leak is mostly theoretical (both values are public information), constant-time comparison is hygiene best practice and silences recurring audit findings.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace Go string != operator with
subtle.ConstantTimeComparefor registry-bound public key comparison inhandshake.go.Details
handshake.go:497regPubKey != msg.PublicKey→subtle.ConstantTimeCompare([]byte(regPubKey), []byte(msg.PublicKey)) != 1crypto/subtleimportRationale
Go's string != operator has early-exit byte comparison, which leaks timing information about the registry-bound pubkey. While both values are public information (the pubkey is public by design), constant-time comparison is a hygiene best practice that silences recurring audit findings.
Verification
go build ./...— passesgo vet ./...— passesgo test ./...— all tests pass (10.6s)Jira: PILOT-93