fix(dataexchange): rename cap→maxFiles to unshadow Go builtin (PILOT-185)#3
Open
matthew-pilot wants to merge 1 commit into
Open
fix(dataexchange): rename cap→maxFiles to unshadow Go builtin (PILOT-185)#3matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
…185) The local variable 'cap' in evictInboxOverflow shadows the Go builtin cap(). Rename to maxFiles to remove the footgun. Closes: PILOT-185
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the local variable
cap→maxFilesinevictInboxOverflowto unshadow the Gocap()builtin. Trivial rename, no behavioral change.What changes
service.go:298-334: renamecap→maxFiles(7 occurrences in one function)Closes: PILOT-185