[diffs] Dynamic FileDiff Hydration#861
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2454eab4c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amadeus
force-pushed
the
amadeus/dynamic-loader
branch
from
132c1d4 to
0e587cb
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
amadeus
force-pushed
the
amadeus/dynamic-loader
branch
from
2483d99 to
df085c2
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df085c23b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amadeus
force-pushed
the
amadeus/dynamic-loader
branch
from
df085c2 to
8ff4b10
Compare
This was a to do that will make the partial diff hydration work a lot more reasonable
Flesh out the core hydration utility function, setup types for the loaders, and add tests to make sure hydration works properly
And some cleanup
This was actually a big bug from before, where we didn't properly handle the changes
amadeus
force-pushed
the
amadeus/dynamic-loader
branch
from
ee57c0b to
411566a
Compare
1 participant
At a high level this PR gives a dev the ability to render a FileDiffMetadata that's partial (parsed from a patch file), and then
hydratethe diff when trying to expand lines by providing an API for devs to load the full file contents on expansion.Additionally there were some extra changes that needed to happen to properly implement this: