[trees] Fix truncation markers showing on filename even when it fits horizontally#840
Open
Pipluppp wants to merge 1 commit into
Open
[trees] Fix truncation markers showing on filename even when it fits horizontally#840Pipluppp wants to merge 1 commit into
Pipluppp wants to merge 1 commit into
Conversation
The overflow logic showed truncation markers whenever its measurement exceeded 1lh (height > 1lh), but subpixel rendering from some browsers and zoom levels may make it go past it, so we add an allowance
|
@Pipluppp is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
Pipluppp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #816, where the truncation markers may show up even when it can fit horizontally. Added a
1pxallowance for when the truncation markers will show up (not confident if this is the right fix for this)Motivation & Context
Reproduced the issues from #816 where on different zoom levels and browsers the truncation markers will show up even if there is enough space.
On my display (with different monitor scaling) the truncation markers show up on the home page and at
trees-dev/density, was able to reproduce it on Chrome, Edge, and Safari (except for Firefox where the issue is non-existent)Unable to reproduce it on firefox.
https://chenhuijing.com/blog/about-subpixel-rendering-in-browsers/
Type of changes
Checklist
How was AI used in generating this PR
Had some help solving the issues with
moonandprotoon initial setup on Windows. Manually reproduced the issues across scalings, zoom, and browsers.Related issues
Fixes #816