Draft
Conversation
|
@ije is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architecture
The editor is based on the Shiki's textmeta tokenizer which also powers diffs components. This PR introduces ZERO dependency.
The editing feature is using a hidden textarea element, which allows you to use UNIX system key binding(control + F/B/A/E/etc...), emoji/non-ascii input without implement them from scratch.
Selections are created via the native web selection API, multiple cursors has been supported.
API
Performance matters
Fast UI response means sound UX. To make the editing smooth, we should consider:
grammar.tokenizeLine2(lineText, ruleStack)TODOS
--diffs-font-family,--diffs-font-size,--diffs-line-heightand--diffs-tab-sizeCSS properties⌘ + C⌘ + X⌘ + V/YTabShift + Tab⌘ + ↑⌘ + ↓⌘ + Z⌘ + Shift + Z⌘ + AfoldingStartMarkerandfoldingStopMarkerFileContentsinputLSPnext version