Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c17d2e321
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const [pathname, setPathname] = useState('/'); | ||
|
|
||
| useEffect(() => { | ||
| setPathname(window.location.pathname); | ||
| }, []); |
There was a problem hiding this comment.
The header now hard-codes pathname to '/' for the initial render and only corrects it in a mount effect, so non-home pages (for example /docs, /playground, /theme) render with the Home tab highlighted until hydration completes. This is a user-visible regression from the previous usePathname() behavior and can also leave stale active-state UI if the header remains mounted across client transitions; derive the path from the Next router instead of window.location in an effect.
Useful? React with 👍 / 👎.
… nuking themselves during local dev
|
Follow-up for the dev memory blowouts I've been seeing— |
|
ehhhh fine, could just be two directories in one app |
2 participants
apps/docs/is nowapps/docs-diffs/andapps/docs-treespackages/docs-sharedStill working through the long tail details.