Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| --diffs-bg-selection-override | ||
| --diffs-bg-selection-number-override | ||
| --diffs-bg-selection-background-override | ||
| --diffs-bg-selection-number-background-override |
There was a problem hiding this comment.
We are removing some of these manual overrides, because it doesn't make sense in the new color-mixed world.
Also theoretically one could override the css mixing variables if they wanted too, but i didn't really want to document that currently and would rather we wait and see if people complain/ask for this stuff.
| right: 0; | ||
| display: flex; | ||
| justify-content: flex-end; | ||
| [data-decoration-bar-start] & { |
There was a problem hiding this comment.
This also adds bar stuff that is mostly not used at the moment, which i will be iterating on in the decorations branch, just wanted these changes in main and wanted to not try and hack up the css more just to get this merged.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19f8081ee6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
19f8081 to
0bc1b15
Compare
0bc1b15 to
5595fb0
Compare
The goal of this commit is to rework the CSS colormixing of background colors in a way that's more powerful and flexible for the different cases. It also adds future support for the decorations API. Basicaly I wanted to get this change in now because it does fix some issues and the unused CSS shouldn't really matter much until decorations get shipped
5595fb0 to
587d7d2
Compare
The goal of this commit is to rework the CSS colormixing of background colors in a way that's more powerful and flexible for the different cases.
It also adds future support for the decorations API.
Basicaly I wanted to get this change in now because it does fix some issues and the unused CSS shouldn't really matter much until decorations get shipped
@mdo if you want to poke around on this and make sure you are happy with the results, also if you have potential changes on certain color mixing architecture as well, let me know (or contribute and we can chat further)
To learn more about it:
AI Summary
AI Architecture Summary
This refactor changes diff backgrounds from a large set of hardcoded per-state colors into a staged CSS composition pipeline. Each row now starts from the base surface, can layer in an optional decoration, annotation, or conflict background, then mixes in diff state such as addition, deletion, or conflict current/incoming, then applies selection tint, and finally applies hover.
Because each stage feeds the next through computed CSS variables, selection and hover now compose on top of the existing row background instead of replacing it. That makes the behavior consistent across normal lines, gutters, annotations, merge conflicts, and future decoration rows.
The new architecture also adds depth-aware CSS hooks for the upcoming decorations API, so nested background decorations and side bars can plug into the same pipeline without needing a separate styling system.