Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
force-pushed
the
amadeus/code-viewer
branch
from
6fa1e6d to
f0a2023
Compare
amadeus
force-pushed
the
amadeus/code-viewer
branch
2 times, most recently
from
7266b31 to
c4fd351
Compare
amadeus
force-pushed
the
amadeus/code-viewer
branch
from
c4fd351 to
12d2410
Compare
amadeus
force-pushed
the
amadeus/code-viewer
branch
from
12d2410 to
12357d6
Compare
amadeus
force-pushed
the
amadeus/code-viewer
branch
from
12357d6 to
50c5e6b
Compare
amadeus
force-pushed
the
amadeus/code-viewer
branch
from
50c5e6b to
9531d44
Compare
amadeus
force-pushed
the
amadeus/code-viewer
branch
from
9531d44 to
b77f835
Compare
amadeus
force-pushed
the
amadeus/code-viewer
branch
from
c886f64 to
b5ff18a
Compare
unclear if this is the right way, but it appears to work for now
There were a bunch of issues unfortunately around fitPerfectly calculations and also misc problems with scroll anchoring that this change mostly resolves (I think).
* Ensure a custom tree is only built on fetch (not on annotation change like before) * Hooked up git status to make the list more descriptive * Misc rebase fixes file tree refactor fix
Less DOM thrash, better mental model for virtualization, and can work in noisier situations when animating scroll
A quick algo that will fall back to instant if the distance is more than 10 viewports away
Seems to work great, and requires minimal work... lfgggg
fix a legit bug in scroll anchor things were falling back to the file/item when a line wasn't fully visible
A mix of a feature request probably and the ability to make CodeViewer far more elegant in handling of sticky headers
makes the changes much more stable
calling instanceChanged on setOptions is probably not worth it since we control the lifecycle with CodeViewer
* Adds a new stickyHeaders prop to CodeViewer * Found a ton of issues in the numeric version of scroll anchoring, that should hopefully now be resolved. * Fixed a ton of misc issues related to how different alignments worked * Fixed tons of bugs with setOptions triggering pendingLayoutAnchor * Fixed a bug where maxScroll did not include padding
mb fix flakey test? Actually fix the column out of sync bug squash me
* Adding paddingTop/Bottom that add flexibility as well remain backwards compatible
Along with proper controlled selection behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP