Virtualization V1 #244
Open
Virtualization V1 #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
3 times, most recently
from
6cca062 to
9a479dd
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
945184c to
c878b0b
Compare
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
c878b0b to
e53f541
Compare
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
893431f to
d125f9a
Compare
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
d125f9a to
b786379
Compare
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
e7ed2c2 to
b537069
Compare
Another aspect that can allow us to make better line calculations
Basically we should not try to infer it from the rendered AST since windowing can break this, so in prep for improved virtualization/windowing we'll instead infer it from the diff directly.
Still needs more AI slop removed, but this is finally the working proof that this shit can wooork
Cleaned up a bunch of AI windowing logic to be more self contained and easier to reason about * you know, like sharing functions and stuff
makes it easier to parse
I still need to take a pass on getting stuff working for lines of code nodes, i think this will be important for safari
This is another piece in attempting to try and minimize the DOM changes we make
* fixed some spelling * fixed some variable types
FileRenderer will need renderRanges soon, but we not there yet...
* moving around functions we'll need to use * extrapolating some types, n stuff
Super rough, but works based on scroll and allowing the elements to be arbitrarily rendered on some scrollable container...
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
e77c214 to
f39b228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature branch to work through supporting virtualization.