Skip to content

Conversation

@cornshakes
Copy link
Contributor

What does this PR aim to accomplish?:

It changes the docker-compose example listening mode to 'ALL', because 'all' doesn't work (anymore?).

How does this PR accomplish the above?:

The current docker-compose file example contains this environment variable:

FTLCONF_dns_listeningMode: 'all'

This was changed to

FTLCONF_dns_listeningMode: 'ALL'

to reflect the current documentation.

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: cornshakes <michael.hopfner@icloud.com>
@cornshakes cornshakes requested a review from a team as a code owner November 9, 2025 16:14
@netlify
Copy link

netlify bot commented Nov 9, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit da105b1
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/6910bdced49a7c000815e1d7
😎 Deploy Preview https://deploy-preview-1307--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yubiuser yubiuser merged commit 2e4e5ea into pi-hole:master Nov 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants