Skip to content

Support stringNode in Config component #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

Support stringNode in Config component #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ services:
tags: [phpstan.broker.dynamicMethodReturnTypeExtension]
arguments:
className: Symfony\Component\Config\Definition\Builder\NodeBuilder
methods: [arrayNode, scalarNode, booleanNode, integerNode, floatNode, enumNode, variableNode]
methods: [arrayNode, scalarNode, stringNode, booleanNode, integerNode, floatNode, enumNode, variableNode]

# NodeBuilder::end() return type
-
Expand Down
2 changes: 2 additions & 0 deletions src/Type/Symfony/Config/ArrayNodeDefinitionPrototypeDynamicReturnTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ final class ArrayNodeDefinitionPrototypeDynamicReturnTypeExtension implements Dy
private const PROTOTYPE_METHODS = [
'arrayPrototype',
'scalarPrototype',
'stringPrototype',
'booleanPrototype',
'integerPrototype',
'floatPrototype',
Expand All @@ -29,6 +30,7 @@ final class ArrayNodeDefinitionPrototypeDynamicReturnTypeExtension implements Dy
private const MAPPING = [
'variable' => 'Symfony\Component\Config\Definition\Builder\VariableNodeDefinition',
'scalar' => 'Symfony\Component\Config\Definition\Builder\ScalarNodeDefinition',
'string' => 'Symfony\Component\Config\Definition\Builder\StringNodeDefinition',
'boolean' => 'Symfony\Component\Config\Definition\Builder\BooleanNodeDefinition',
'integer' => 'Symfony\Component\Config\Definition\Builder\IntegerNodeDefinition',
'float' => 'Symfony\Component\Config\Definition\Builder\FloatNodeDefinition',
Expand Down
1 change: 1 addition & 0 deletions src/Type/Symfony/Config/TreeBuilderDynamicReturnTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ final class TreeBuilderDynamicReturnTypeExtension implements DynamicStaticMethod
private const MAPPING = [
'variable' => 'Symfony\Component\Config\Definition\Builder\VariableNodeDefinition',
'scalar' => 'Symfony\Component\Config\Definition\Builder\ScalarNodeDefinition',
'string' => 'Symfony\Component\Config\Definition\Builder\StringNodeDefinition',
'boolean' => 'Symfony\Component\Config\Definition\Builder\BooleanNodeDefinition',
'integer' => 'Symfony\Component\Config\Definition\Builder\IntegerNodeDefinition',
'float' => 'Symfony\Component\Config\Definition\Builder\FloatNodeDefinition',
Expand Down
7 changes: 7 additions & 0 deletions tests/Type/Symfony/data/tree_builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,13 @@
assertType('Symfony\Component\Config\Definition\Builder\ScalarNodeDefinition', $scalarRootNode->defaultValue("default"));
assertType('Symfony\Component\Config\Definition\Builder\TreeBuilder', $scalarRootNode->defaultValue("default")->end());

$stringTreeBuilder = new TreeBuilder('my_tree', 'string');
$stringRootNode = $stringTreeBuilder->getRootNode();

assertType('Symfony\Component\Config\Definition\Builder\StringNodeDefinition', $stringRootNode);
assertType('Symfony\Component\Config\Definition\Builder\StringNodeDefinition', $stringRootNode->defaultValue("default"));
assertType('Symfony\Component\Config\Definition\Builder\TreeBuilder', $stringRootNode->defaultValue("default")->end());

$booleanTreeBuilder = new TreeBuilder('my_tree', 'boolean');
$booleanRootNode = $booleanTreeBuilder->getRootNode();

Expand Down
Loading