Repository navigation
Keep the restart ini out of the container key - #6834
Merged
ondrejmirtes merged 1 commit intoOct 25, 2026
Merged
Conversation
The restart points PHPRC at a temporary ini with a random name and empties PHP_INI_SCAN_DIR. The container key includes the environment, so each restarted run built a new container. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
|
Thank you! |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The restart points
PHPRCat a temporary ini with a random name, and it emptiesPHP_INI_SCAN_DIR. The container key includes the environment, apart from a few named variables, so each run that restarts this way builds a new container. A warm run pays for that every time.PHPStan 2.3.2 at level 5 on Rector's
rules/(759 files), against the same phar with this change patched in:Both report the same 2,684 errors. Rector restarts through the same code, and its warm runs on the runner go from 0.91–0.92 s to 0.65–0.66 s.
#5927 would also cover this, because it keys the container only on the variables a config references. This change is the narrow version for the two variables the restart sets.
🤖 Generated with Claude Code