Fix the type of the options of the RedisArray constructor - #6399
Open
mlocati wants to merge 1 commit into
Open
Conversation
Collaborator
|
You've opened the pull request against the latest branch 2.3.x. PHPStan 2.3 is not going to be released for months. If your code is relevant on 2.2.x and you want it to be released sooner, please rebase your pull request and change its target to 2.2.x. |
The options may have any type: for example, connect_timeout and read_timeout are numbers, lazy_connect and consistent are booleans, function and distributor are callables, previous is an array. See the phpredis documentation of RedisArray: https://github.com/phpredis/phpredis/blob/develop/arrays.md and the phpredis stub of the constructor: https://github.com/phpredis/phpredis/blob/develop/redis_array.stub.php
mlocati
force-pushed
the
redis-array-options-type
branch
from
September 8, 2026 14:59
93fa9f6 to
0af0a71
Compare
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The options may have any type: for example,
connect_timeoutandread_timeoutare numbers,lazy_connectandconsistentare booleans,functionanddistributorare callables,previousis an array.See the phpredis documentation of RedisArray:
https://github.com/phpredis/phpredis/blob/develop/arrays.md
and the phpredis stub of the constructor:
https://github.com/phpredis/phpredis/blob/develop/redis_array.stub.php