Fix flickering of trait errors deduplicated into the trait file

.github/workflows/e2e-tests.yml

@@ -321,12 +321,17 @@ jobs:
               ../../bin/phpstan clear-result-cache
               OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan --error-format=raw")
               ../bashunit -a contains 'FooTrait.php:10:Strict comparison using === between int<0, max> and false will always evaluate to false.' "$OUTPUT"
-              # An ignoreErrors path may target the error by the trait file or by the using-class
-              # file - both keep working (no BC break).
+              # The deduplicated error is attributed to the trait file: an ignoreErrors path
+              # targeting the trait file matches, a using-class path does not - consistently
+              # with both an empty and a primed result cache.
               ../../bin/phpstan clear-result-cache
               ../bashunit -a exit_code "0" "../../bin/phpstan analyse --error-format=raw -c ignore-trait-path.neon"
+              ../bashunit -a exit_code "0" "../../bin/phpstan analyse --error-format=raw -c ignore-trait-path.neon"
               ../../bin/phpstan clear-result-cache
-              ../bashunit -a exit_code "0" "../../bin/phpstan analyse --error-format=raw -c ignore-class-path.neon"
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse --error-format=raw -c ignore-class-path.neon")
+              ../bashunit -a contains 'FooTrait.php:10:Strict comparison using === between int<0, max> and false will always evaluate to false.' "$OUTPUT"
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse --error-format=raw -c ignore-class-path.neon")
+              ../bashunit -a contains 'FooTrait.php:10:Strict comparison using === between int<0, max> and false will always evaluate to false.' "$OUTPUT"
               # A generated baseline suppresses the error on re-run, with both an empty and a
               # primed result cache (the issue reported baseline generation as impossible).
               ../../bin/phpstan --generate-baseline=baseline.neon

build/baseline-8.0.neon

@@ -22,4 +22,4 @@ parameters:
 			message: '#^Strict comparison using \=\=\= between list\<non\-falsy\-string\> and false will always evaluate to false\.$#'
 			identifier: identical.alwaysFalse
 			count: 1
-			path: ../src/Type/Php/StrSplitFunctionReturnTypeExtension.php
+			path: ../src/Type/Php/MbFunctionsReturnTypeExtensionTrait.php

src/Analyser/AnalyserResultFinalizer.php

@@ -14,6 +14,7 @@
 use function array_merge;
 use function count;
 use function get_class;
+use function ksort;
 use function sprintf;
 
 #[AutowiredService]
@@ -44,7 +45,9 @@ public function finalize(AnalyserResult $analyserResult, bool $onlyFiles, bool $
 		}
 
 		$nodeType = CollectedDataNode::class;
-		$node = new CollectedDataNode($analyserResult->getCollectedData(), $onlyFiles);
+		$collectedData = $analyserResult->getCollectedData();
+		ksort($collectedData);
+		$node = new CollectedDataNode($collectedData, $onlyFiles);
 
 		$file = 'N/A';
 		$scope = $this->scopeFactory->create(ScopeContext::create($file));

src/Analyser/Error.php

@@ -117,7 +117,7 @@ public function removeTraitContext(): self
 			$this->traitFilePath,
 			$this->line,
 			$this->canBeIgnored,
-			$this->filePath,
+			$this->traitFilePath,
 			$this->traitFilePath,
 			$this->tip,
 			$this->nodeLine,

tests/PHPStan/Analyser/ErrorTest.php

@@ -25,14 +25,19 @@ public function testRemoveTraitContextKeepsTraitFilePath(): void
 		$withoutTraitContext = $error->removeTraitContext();
 		// The error is now reported directly in the trait: the displayed file is
 		// the trait, and traitFilePath is kept so the editor URL and the
-		// trait-file ignore lookups resolve to the trait (#14718). filePath stays
-		// the using-class file, so an ignoreErrors path keyed on either the trait
-		// or the using-class file keeps matching (no BC break).
+		// trait-file ignore lookups resolve to the trait (#14718).
 		$this->assertSame('trait.php', $withoutTraitContext->getFile());
-		$this->assertSame('user.php', $withoutTraitContext->getFilePath());
 		$this->assertSame('trait.php', $withoutTraitContext->getTraitFilePath());
 	}
 
+	public function testRemoveTraitContextAttributesErrorToTraitFile(): void
+	{
+		$error = new Error('Message', 'trait.php (in context of class C)', 11, true, 'user.php', 'trait.php');
+
+		$withoutTraitContext = $error->removeTraitContext();
+		$this->assertSame('trait.php', $withoutTraitContext->getFilePath());
+	}
+
 	public static function dataValidIdentifier(): iterable
 	{
 		yield ['a'];