Skip to content

Fix phpstan/phpstan#11100: Possibly impure call to function array_map() in pure method - false positive #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phpstan-bot wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
Open

Fix phpstan/phpstan#11100: Possibly impure call to function array_map() in pure method - false positive #5197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/functionMetadata_original.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
'array_key_last' => ['hasSideEffects' => false],
'array_key_exists' => ['hasSideEffects' => false],
'array_keys' => ['hasSideEffects' => false],
'array_map' => ['hasSideEffects' => false],
'array_merge' => ['hasSideEffects' => false],
'array_merge_recursive' => ['hasSideEffects' => false],
'array_pad' => ['hasSideEffects' => false],
Expand Down
1 change: 1 addition & 0 deletions resources/functionMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,7 @@
'array_key_last' => ['hasSideEffects' => false],
'array_keys' => ['hasSideEffects' => false],
'array_last' => ['hasSideEffects' => false],
'array_map' => ['hasSideEffects' => false],
'array_merge' => ['hasSideEffects' => false],
'array_merge_recursive' => ['hasSideEffects' => false],
'array_pad' => ['hasSideEffects' => false],
Expand Down
7 changes: 7 additions & 0 deletions tests/PHPStan/Rules/Pure/PureMethodRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,13 @@ public function testAllMethodsArePure(): void
]);
}

#[RequiresPhp('>= 8.0')]
public function testBug11100(): void
{
$this->treatPhpDocTypesAsCertain = true;
$this->analyse([__DIR__ . '/data/bug-11100.php'], []);
}

public function testBug12382(): void
{
$this->treatPhpDocTypesAsCertain = true;
Expand Down
32 changes: 32 additions & 0 deletions tests/PHPStan/Rules/Pure/data/bug-11100.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php // lint >= 8.0

declare(strict_types = 1);

namespace Bug11100;

final class FooClass
{
/**
* @param array<string, string|int> $getParams
*
* @phpstan-pure
*/
public function build(array $getParams, string $trailingSlash, bool $useSlashSeparator): string
{
if ($getParams === []) {
return '';
}

if ($useSlashSeparator) {
return '/' . implode('/', array_map(
static function (string $key, string|int $value): string {
return rawurlencode($key) . '/' . rawurlencode((string) $value);
},
array_keys($getParams),
$getParams
)) . $trailingSlash;
}

return $trailingSlash . '?' . http_build_query($getParams);
}
}
Loading