Fix phpstan/phpstan#12246: crash on first class callable as conditional do while

[phpstan-bot]

Summary

Using a first-class callable (e.g. $this->textElement(...)) as a do...while loop condition caused a crash: Call to undefined method PHPStan\Node\Printer\Printer::pPHPStan_Node_MethodCallableNode(). This fix adds the missing printer methods for all callable node types.

Changes

• Added pPHPStan_Node_MethodCallableNode() to src/Node/Printer/Printer.php
• Added pPHPStan_Node_FunctionCallableNode() to src/Node/Printer/Printer.php
• Added pPHPStan_Node_StaticMethodCallableNode() to src/Node/Printer/Printer.php
• Added pPHPStan_Node_InstantiationCallableNode() to src/Node/Printer/Printer.php
• Each method delegates to printing the original PHP-Parser AST node via getOriginalNode()
• Added regression test in tests/PHPStan/Analyser/data/bug-12246.php
• Added test method testBug12246 in tests/PHPStan/Analyser/AnalyserIntegrationTest.php

Root cause

When a first-class callable is used as a do...while condition, NodeScopeResolver converts the MethodCall to a MethodCallableNode and processes it. At the end of processExprNode, the truthy/falsey scope callbacks call $scope->filterByTruthyValue($expr) with the MethodCallableNode. This calls getNodeKey() which uses ExprPrinter::printExpr(), which delegates to the Printer class. The Printer (extending PhpParser\PrettyPrinter\Standard) looks for a method named pPHPStan_Node_MethodCallableNode() based on the node's getType() return value, but no such method existed.

The fix adds printer methods for all four callable node types (FunctionCallableNode, MethodCallableNode, StaticMethodCallableNode, InstantiationCallableNode), each delegating to printing the original call expression node.

Test

The regression test uses a do...while loop with $this->textElement(...) as the condition. Without the fix, this crashes with the printer error. With the fix, PHPStan correctly reports that the do-while condition is always true (since a Closure is always truthy).

Fixes phpstan/phpstan#12246

[staabm]

I verified that all added methods are covered by a test which crashes without the methods beeing present

[VincentLanglet]

I dunno this class but all other methods use sprintf for the implementation, why not the new methods ?