Fix phpstan/phpstan#14215: Nonexistent offset detection on lists with count() -1
#5116
+168
−14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| <?php declare(strict_types = 1); | ||
|
|
||
| namespace Bug14215; | ||
|
|
||
| class HelloWorld | ||
| { | ||
| /** | ||
| * @param list<int> $array | ||
| * @param positive-int $index | ||
| */ | ||
| public function positiveIntLessThanCountMinusOne(array $array, int $index): int | ||
| { | ||
| if ($index < count($array) - 1) { | ||
| return $array[$index]; // should not report | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| /** | ||
| * @param list<int> $array | ||
| * @param positive-int $index | ||
| */ | ||
| public function positiveIntLessThanOrEqualCountMinusOne(array $array, int $index): int | ||
| { | ||
| if ($index <= count($array) - 1) { | ||
| return $array[$index]; // should not report | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| /** | ||
| * @param list<int> $array | ||
| */ | ||
| public function intLessThanOrEqualCountMinusOne(array $array, int $index): int | ||
| { | ||
| if ($index <= count($array) - 1) { | ||
| return $array[$index]; // should error report, could be negative int | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| /** | ||
| * @param list<int> $array | ||
| * @param int<0, max> $index | ||
| */ | ||
| public function nonNegativeIntLessThanCountMinusOne(array $array, int $index): int | ||
| { | ||
| if ($index < count($array) - 1) { | ||
| return $array[$index]; // should not report | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| /** | ||
| * @param list<int> $array | ||
| * @param int<0, max> $index | ||
| */ | ||
| public function nonNegativeIntLessThanOrEqualCountMinusOne(array $array, int $index): int | ||
| { | ||
| if ($index <= count($array) - 1) { | ||
| return $array[$index]; // should not report | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| /** | ||
| * @param list<int> $array | ||
| * @param positive-int $index | ||
| */ | ||
| public function positiveIntLessThanCountMinusTwo(array $array, int $index): int | ||
| { | ||
| if ($index < count($array) - 2) { | ||
| return $array[$index]; // should not report | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| /** | ||
| * @param list<int> $array | ||
| * @param positive-int $index | ||
| */ | ||
| public function positiveIntLessThanOrEqualCountMinusTwo(array $array, int $index): int | ||
| { | ||
| if ($index <= count($array) - 2) { | ||
| return $array[$index]; // should not report | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| /** | ||
| * @param list<int> $array | ||
| * @param positive-int $index | ||
| */ | ||
| public function positiveIntLessThanSizeofMinusOne(array $array, int $index): int | ||
| { | ||
| if ($index < sizeof($array) - 1) { | ||
| return $array[$index]; // should not report | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| /** | ||
| * @param list<int> $array | ||
| * @param positive-int $index | ||
| */ | ||
| public function positiveIntGreaterThanCountMinusOneInversed(array $array, int $index): int | ||
| { | ||
| if (count($array) - 1 > $index) { | ||
| return $array[$index]; // should not report | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the bot is trying to support thing like