Fix #12253: assign.readOnlyProperty

src/Node/ClassPropertiesNode.php

@@ -166,10 +166,9 @@ public function getUninitializedProperties(
 			$initializedInConstructor = array_diff_key($uninitializedProperties, $this->collectUninitializedProperties([$classReflection->getConstructor()->getName()], $uninitializedProperties));
 		}
 
-		$methodsCalledFromConstructor = $this->getMethodsCalledFromConstructor($classReflection, $initialInitializedProperties, $initializedProperties, $constructors, $initializedInConstructor);
+		$methodsCalledFromConstructor = $this->getMethodsCalledFromConstructor($classReflection, $initialInitializedProperties, $initializedProperties, $constructors, $initializedInConstructor, $constructors);
 		$prematureAccess = [];
 		$additionalAssigns = [];
-
 		foreach ($this->getPropertyUsages() as $usage) {
 			$fetch = $usage->getFetch();
 			if (!$fetch instanceof PropertyFetch) {
@@ -211,7 +210,10 @@ public function getUninitializedProperties(
 
 			if ($usage instanceof PropertyWrite) {
 				if (array_key_exists($propertyName, $initializedPropertiesMap)) {
-					$hasInitialization = $initializedPropertiesMap[$propertyName]->or($usageScope->hasExpressionType(new PropertyInitializationExpr($propertyName)));
+					$hasInitialization = $initializedPropertiesMap[$propertyName];
+					if (strtolower($function->getName()) === '__construct') {
+						$hasInitialization = $hasInitialization->or($usageScope->hasExpressionType(new PropertyInitializationExpr($propertyName)));
+					}
 					if (
 						!$hasInitialization->no()
 						&& !$usage->isPromotedPropertyWrite()
@@ -318,6 +320,7 @@ private function collectUninitializedProperties(array $constructors, array $unin
 	 * @param array<string, TrinaryLogic> $initialInitializedProperties
 	 * @param array<string, array<string, TrinaryLogic>> $initializedProperties
 	 * @param array<string, ClassPropertyNode> $initializedInConstructorProperties
+	 * @param string[] $originalConstructors
 	 *
 	 * @return array<string, array<string, TrinaryLogic>>
 	 */
@@ -327,6 +330,7 @@ private function getMethodsCalledFromConstructor(
 		array $initializedProperties,
 		array $methods,
 		array $initializedInConstructorProperties,
+		array $originalConstructors,
 	): array
 	{
 		$originalMap = $initializedProperties;
@@ -363,7 +367,7 @@ private function getMethodsCalledFromConstructor(
 				continue;
 			}
 
-			if ($inMethod->getName() !== '__construct') {
+			if ($inMethod->getName() !== '__construct' && in_array($inMethod->getName(), $originalConstructors, true)) {
 				foreach (array_keys($initializedInConstructorProperties) as $propertyName) {
 					$initializedProperties[$inMethod->getName()][$propertyName] = TrinaryLogic::createYes();
 				}
@@ -391,7 +395,7 @@ private function getMethodsCalledFromConstructor(
 			return $initializedProperties;
 		}
 
-		return $this->getMethodsCalledFromConstructor($classReflection, $initialInitializedProperties, $initializedProperties, $methods, $initializedInConstructorProperties);
+		return $this->getMethodsCalledFromConstructor($classReflection, $initialInitializedProperties, $initializedProperties, $methods, $initializedInConstructorProperties, $originalConstructors);
 	}
 
 	/**

tests/PHPStan/Rules/Properties/MissingReadOnlyPropertyAssignRuleTest.php

@@ -342,4 +342,10 @@ public function testBug11828(): void
 		$this->analyse([__DIR__ . '/data/bug-11828.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.4')]
+	public function testBug12253(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-12253.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/bug-12253.php

@@ -0,0 +1,87 @@
+<?php // lint >= 8.4
+
+declare(strict_types = 1);
+
+namespace Bug12253;
+
+use stdClass;
+
+class Payload
+{
+	/** @var array<array<string, mixed>> */
+	private(set) readonly array $validation;
+
+	/** @var array<string, string> */
+	private array $ids = [];
+
+	public function __construct(private readonly stdClass $payload)
+	{
+		$this->parseValidation();
+	}
+
+	private function parseValidation(): void
+	{
+		$validations = [];
+
+		foreach ($this->payload->validation as $key => $validation) {
+			$validations[] = [
+				'id' => $key,
+				'field_id' => $this->ids[$validation->field_id],
+				'rule' => $validation->rule,
+				'value' => $this->validationValue($validation->value),
+				'message' => $validation->message,
+			];
+		}
+
+		$this->validation = $validations;
+	}
+
+	private function validationValue(mixed $value): mixed
+	{
+		if (is_null($value)) {
+			return null;
+		}
+
+		return $this->ids[$value] ?? $value;
+	}
+}
+
+class PayloadWithoutAsymmetricVisibility
+{
+	/** @var array<array<string, mixed>> */
+	private readonly array $validation;
+
+	/** @var array<string, string> */
+	private array $ids = [];
+
+	public function __construct(private readonly stdClass $payload)
+	{
+		$this->parseValidation();
+	}
+
+	private function parseValidation(): void
+	{
+		$validations = [];
+
+		foreach ($this->payload->validation as $key => $validation) {
+			$validations[] = [
+				'id' => $key,
+				'field_id' => $this->ids[$validation->field_id],
+				'rule' => $validation->rule,
+				'value' => $this->validationValue($validation->value),
+				'message' => $validation->message,
+			];
+		}
+
+		$this->validation = $validations;
+	}
+
+	private function validationValue(mixed $value): mixed
+	{
+		if (is_null($value)) {
+			return null;
+		}
+
+		return $this->ids[$value] ?? $value;
+	}
+}