[PHP 8.5] ini_get("max_memory_limit") is a string

[staabm]

No description provided.

[ondrejmirtes]

This works in type inference tests? 😱 Can you point to a piece of code that makes it work? We might want to refactor some tests thanks to this.

[staabm]

I think it works because the constant PHP_VERSION_ID is narrowed via expressionTypes and these are taken into account in MutatingScope->getPhpVersion() via

phpstan-src/src/Analyser/MutatingScope.php

Line 6330 in 2674c0f

$constType = $this->getGlobalConstantType(new Name('PHP_VERSION_ID'));

(it works as long as the relevant extensions utilize $scope->getPhpVersion() instead of a injected PhpVersion from the DIC)

[ondrejmirtes]

Yeah, that makes sense! I thought that TypeInferenceTestCase somehow skips the asserts if they are for a different PHP version.

[ondrejmirtes]

This test fails though https://github.com/phpstan/phpstan-src/actions/runs/19663206996/job/56313831308?pr=4574

[staabm]

good catch. this was a proof of concept that it actually works ;)

[ondrejmirtes]

Thank you!