feat: add dynamic parameter type extensions #4290
Conversation
calebdw
force-pushed
the
dynamic_parameter_extension
branch
4 times, most recently
from
49c7da8 to
58e51fb
Compare
calebdw
force-pushed
the
dynamic_parameter_extension
branch
from
58e51fb to
79de0a6
Compare
|
This pull request has been marked as ready for review. |
|
I tested it by porting my previous implementation for Larastan to this one, and looks like it works fine! Will try to implement more use cases and see if I can find any bugs. Also will try to test it on real projects.But so far so good. Thanks for this! I'll also try to review this PR (though Ondrej would do a better job 😄 ) |
calebdw
force-pushed
the
dynamic_parameter_extension
branch
from
79de0a6 to
7c605c1
Compare
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
This looks solid, just a few questions as a start, will do deep review later 👍
src/Analyser/ExpressionContext.php
Outdated
| return new self($this->isDeep, $this->inAssignRightSideVariableName, $this->inAssignRightSideType, $this->inAssignRightSideNativeType, $type); | ||
| } | ||
|
|
||
| public function getOverriddenType(): ?Type |
There was a problem hiding this comment.
Why this does have to be here actually at all? Why hasn't been the passedToType parameter kept? Why is this named "overriden type"? What is it overriding?
There was a problem hiding this comment.
I've refactored this PR to simply pass the variable around through the methods instead of trying to use the ExpressionContext.
Why hasn't been the passedToType parameter kept? Why is this named "overriden type"?
It has been kept, I just renamed $passedToType to $overriddenType---"passed to type" didn't make any sense so I renamed it.
What is it overriding?
This is the overriding type coming from the dynamic parameter type extensions. The extensions are "overriding" the type that phpstan thinks they should be. If you have a better name in mind then I'm all ears.
|
@calebdw @ondrejmirtes Sorry to bother you, but I wanted to ask how we can move this forward? I'm really interested in this feature. |
|
No worries, just been busy with personal life, I'll try to get to the comments soon |
calebdw
force-pushed
the
dynamic_parameter_extension
branch
2 times, most recently
from
b9ce6ac to
b293d32
Compare
|
@ondrejmirtes, @canvural, sorry it took so long to address these comments---just been busy with personal life but hoping to move this forward now 🙏 |
calebdw
force-pushed
the
dynamic_parameter_extension
branch
from
b293d32 to
16430bf
Compare
4 participants
Closes phpstan/phpstan#11707, closes phpstan/phpstan#12585
Supersedes #3828, supersedes #3131, supersedes #3823
Hello!
This adds generalized dynamic parameter type extensions and deprecates the parameter closure type extensions per phpstan/phpstan#11707 (comment).
This also fixes the
return.typeand theargument.typeerrors described in phpstan/phpstan#12585 when the parameter type is overridden via the extension.Note
The original type from the closure type extensions was being passed around as
$passedToTypeto the methods that needed it. However, I opted to rename this tooverriddenTypesince I wasn't quite sure what$passedToTypereally meant. Let me know if there's something you'd rather do differently.CC: @canvural, @Neol3108
Thanks!