Skip to content

Conversation

@Jibbarth
Copy link
Contributor

Q A
Branch v2.x
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets comma-separated list of tickets fixed by the PR, if any

⚠️ Can't be tested right now, some dependencies don't yet allow SF8

@arnedesmedt
Copy link

arnedesmedt commented Dec 1, 2025

You will also need to get rid of the !tagged attributes in the runner.yml. !tagged_iterator should be used now.
And xml loaders are no longer supported.

@Jibbarth
Copy link
Contributor Author

Jibbarth commented Dec 2, 2025

Agreed, it deserve more work I expected initially 🤔

@veewee veewee mentioned this pull request Dec 3, 2025
@veewee veewee force-pushed the feature/support-sf8 branch from a1856a6 to 4df44ed Compare December 3, 2025 07:44
@veewee veewee added the dependencies Pull requests that update a dependency file label Dec 3, 2025
@veewee veewee merged commit 35fcd33 into phpro:v2.x Dec 3, 2025
25 of 26 checks passed
@veewee
Copy link
Contributor

veewee commented Dec 3, 2025

Thanks!

@Jibbarth
Copy link
Contributor Author

Jibbarth commented Dec 3, 2025

Thank you @veewee for finishing it 🤩

@Jibbarth Jibbarth deleted the feature/support-sf8 branch December 3, 2025 09:31
@arnedesmedt
Copy link

Txh! @veewee I think the loader factory would still need a change. If I update to the v2.x version, I still get

PHP Fatal error: Uncaught Error: Class "Symfony\Component\DependencyInjection\Loader\XmlFileLoader"

So I think we first should check if the XmlFileLoader class exists in the LoaderFactory, if not, don't initiate it, and add it to the list of loaders.

WDYT?

@veewee
Copy link
Contributor

veewee commented Dec 3, 2025

Ah yes, you are right.

It thought it just got deprecated, but it is actually removed in SF 8.0.
Now wondering why the CI did not fail ... It seems to be installing 7.4 for some (probably dependency) reason.

@veewee veewee mentioned this pull request Dec 3, 2025
@veewee
Copy link
Contributor

veewee commented Dec 3, 2025

@arnedesmedt continuing here
#1199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants