-
Notifications
You must be signed in to change notification settings - Fork 442
Add support for Symfony 8.0 #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jibbarth
commented
Nov 23, 2025
| Q | A |
|---|---|
| Branch | v2.x |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Documented? | no |
| Fixed tickets | comma-separated list of tickets fixed by the PR, if any |
|
You will also need to get rid of the !tagged attributes in the runner.yml. !tagged_iterator should be used now. |
|
Agreed, it deserve more work I expected initially 🤔 |
a1856a6 to
4df44ed
Compare
|
Thanks! |
|
Thank you @veewee for finishing it 🤩 |
|
Txh! @veewee I think the loader factory would still need a change. If I update to the v2.x version, I still get
So I think we first should check if the XmlFileLoader class exists in the LoaderFactory, if not, don't initiate it, and add it to the list of loaders. WDYT? |
|
Ah yes, you are right. It thought it just got deprecated, but it is actually removed in SF 8.0. |
|
@arnedesmedt continuing here |