Add allow-list functionality to securitychecker_enlightn #1161
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterjaap
commented
Nov 19, 2024
peterjaap
commented
| Q | A |
|---|---|
| Branch | v2.x |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Documented? | yes |
veewee
requested changes
Nov 26, 2024
Contributor
veewee
left a comment
veewee
left a comment
There was a problem hiding this comment.
Looks like a nice addition, thanks!
Can you make sure to add a test-case for this new allow_list argument? Otherwise we won't be able to merge this.
Contributor
Author
|
@veewee I've added a test case and used |
veewee
requested changes
Dec 3, 2024
Contributor
veewee
left a comment
veewee
left a comment
There was a problem hiding this comment.
Thanks. It's curently not working as expected.
I've added some additional pointers in code.
| $resolver->setDefaults([ | ||
| 'lockfile' => './composer.lock', | ||
| 'run_always' => false, | ||
| 'allow_list' => [] |
Contributor
There was a problem hiding this comment.
The method provideConfigurableOptions in the test should be altered to cover this newly added default.
|
@peterjaap nice addition. This is something i could use as well. Thanks for adding it. When will you have time to look at the changes needed? |
- Document new option in enlightn.md with example usage - Fix argument formatting to use comma-separated values for --allow-list - Update unit test to include the new option in default configuration This change allows users to specify CVEs that should be ignored during security checks when they've been assessed and determined not to pose a risk.
Contributor
Author
|
@veewee I processed your remarks |
Contributor
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.