Repository navigation
Plan optional first-view-only counting in TODO - #1
Merged
Merged
Conversation
Add an opt-in setting to count only the first view of a topic per session, since phpBB's own repeat-view check misses ?t=N and ?p=N links and matches the wrong topic. Also point the waiting item at the filed ticket (PHPBB-17745) and core pull request (phpbb/phpbb#7092). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in "count only the first view of a topic per session" setting to the build plan in
docs/TODO.md.phpBB's own repeat-view check in
viewtopic.phplooks for'&t=' . $topic_idinsession_page. Claude tested it on a 3.3.19 board: reloads ofviewtopic.php?t=Nandviewtopic.php?p=Ncount every time, and a view of topic 1 right after topic 12 is skipped. A maintainer said in PHPBB-16989 that counting every view is intended, so this stays off by default.Also updates the "Waiting on phpBB" item now that PHPBB-17745 is filed and phpbb/phpbb#7092 is open.
Investigated and written by Claude on behalf of William Jacoby (bonelifer).