Repository navigation
Move the IP lookup controller to controller/ and rename the install language file - #9
Merged
Merged
Conversation
…anguage file core/freegeoip.php becomes controller/freegeoip.php, with its namespace, service and route names to match, and posteripinviewtopic_install.php becomes install_posteripinviewtopic.php, as in the other phpbbmodders extensions. The route's URL is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the file layout in line with the other phpbbmodders extensions:
core/freegeoip.phpmoves tocontroller/freegeoip.php. Its namespace, service ID (phpbbmodders.posteripinviewtopic.controller.freegeoip) and route name (phpbbmodders_posteripinviewtopic_controller_freegeoip) change to match. The route's URL,/freegeoip/{post_id}, stays the same.language/en/posteripinviewtopic_install.phpbecomesinstall_posteripinviewtopic.php, and theadd_lang()call inext.phpis updated.Claude ran
smoke_test.pyon a seed-forum test board (clean, including a disable → delete data → enable round trip), then the screenshot run, which clicks a post's IP address and shows the lookup popup served by the moved controller.Investigated and written by Claude on behalf of William Jacoby (bonelifer).