Repository navigation
Let forum moderators look up a poster's IP - #10
Merged
Merged
Conversation
The lookup required both a global admin or moderator permission and moderator permission in the post's forum, so moderators of a single forum saw the IP link but got 403. It now accepts either, matching the check that shows the link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moderators of a single forum saw the IP address link on that forum's posts, but clicking it returned 403 Not authorised.
The listener shows the link to admins, global moderators, or moderators of the post's forum. The lookup controller joined the same two checks with
||on their negations, so it required both a global admin/moderator permission and moderator permission in the forum. It now uses&&, so it allows the same users who see the link.Claude added a feature check for this in phpbbmodders/phpbb-release-tools (
feature_checks.py). Onmasterit fails ("moderator of the forum can look the IP up"); with this change all 7 checks pass. The check covers an administrator, a moderator of the forum only, and a member without moderator permissions, who still gets 403.Investigated and written by Claude on behalf of William Jacoby (bonelifer).