Skip to content

Fix migration test constructors for phpBB 4.0 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bonelifer merged 1 commit into from
Oct 18, 2026
Merged

Fix migration test constructors for phpBB 4.0 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/kb_match_key_repair_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class kb_match_key_repair_test extends \PHPUnit\Framework\TestCase

private function migration($db): version_2_0_25
{
return new version_2_0_25(new \phpbb\config\config(['kb_version' => '2.0.24']), $db, $this->createMock(\phpbb\db\tools\tools_interface::class), '', 'php', 'phpbb_');
return new version_2_0_25(new \phpbb\config\config(['kb_version' => '2.0.24']), $db, $this->createMock(\phpbb\db\tools\tools_interface::class), '', 'php', 'phpbb_', []);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/kb_search_key_migration_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ private function run_add_key(array $indexes, string $layer = 'mysqli'): array
return array_shift($rows) ?? false;
});

$migration = new version_1_0_3(new \phpbb\config\config([]), $db, $this->createMock(\phpbb\db\tools\tools_interface::class), '', 'php', 'phpbb_');
$migration = new version_1_0_3(new \phpbb\config\config([]), $db, $this->createMock(\phpbb\db\tools\tools_interface::class), '', 'php', 'phpbb_', []);
$migration->add_key();

return $queries;
Expand Down
2 changes: 1 addition & 1 deletion tests/kb_upload_directory_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public function test_attachments_stay_where_they_are_when_the_new_folder_cannot_

public function test_the_migration_moves_the_attachments_and_sets_the_version()
{
$migration = new \phpbbmodders\knowledgebase\migrations\version_2_0_28(new \phpbb\config\config([]), $this->createMock(\phpbb\db\driver\driver_interface::class), $this->createMock(\phpbb\db\tools\tools_interface::class), $this->root, 'php', 'phpbb_');
$migration = new \phpbbmodders\knowledgebase\migrations\version_2_0_28(new \phpbb\config\config([]), $this->createMock(\phpbb\db\driver\driver_interface::class), $this->createMock(\phpbb\db\tools\tools_interface::class), $this->root, 'php', 'phpbb_', []);
$this->legacy_file('moved.dat');

$this->assertSame(['\phpbbmodders\knowledgebase\migrations\version_2_0_27'], $migration::depends_on());
Expand Down