Repository navigation
Fix validation findings - #2
Merged
Merged
Conversation
- Head link titles use the FEEDLINKS_RSS language string instead of a hard-coded "(RSS)", and escape their language strings. - A failed RSS conversion shows a language-string error (500) instead of the converter's English exception message. - The feed link titles escape their language string before adding the already-escaped forum name. - Remove template variables no template used, and use links::NONE instead of a bare 0. - Update the quoted link wording in the template event request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the findings from a validation pass on 1.0.0-dev (
7a5d2e5), run with the standard phpBB validation prompt.(RSS)written into their titles. They now use theFEEDLINKS_RSSlanguage string, and the language strings in thosetitleattributes are escaped.FEEDLINKS_RSS_ERROR) with a 500 status.U_FEEDLINKS_ATOM, and the forum row URL variables), and addedlinks::NONEin place of a bare0.docs/events/forumlist_body_forum_desc_after.txt, the request filed as PHPBB-17748.Claude ran the unit tests (44 pass on phpBB 3.3.x and master), EPV for 3.3 and 4.0 (no Fatal or Error),
php -l, the template accessibility check, and both seed-forum test boards (RSS feeds, head links, and link titles with a forum named "Tom & Jerry").Investigated and written by Claude on behalf of William Jacoby (bonelifer).