Repository navigation
Add RSS feeds and per-forum Atom/RSS feed links - #1
Merged
Merged
Conversation
RSS 2.0 versions of every phpBB feed, served by phpBB's own feed controller and converted from its Atom output, so feed settings, permissions and events apply to both formats. Each forum gets a "Show feed links" setting (none, Atom, RSS or both) for links below its description on the board index and on the forum page, and RSS discovery links in the page head. phpBB's feed HTTP authentication covers the RSS routes too. Supports phpBB 3.3.19+ and 4.0, PHP 7.4+. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
phpBB 3.3's forum rows start the moderators line with <br />; after a block element that left an empty line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each link gets the feed icon and a dotted underline, as on phpBB.com. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version of Feed Links, a new extension for phpBB 3.3.19+ and 4.0.
What it does
app.php/rss/...for every feed phpBB has as Atom: board, forum, topic, news, all forums, new topics, active topics. They run phpBB's own feed controller and convert its Atom output, so feed settings, permissions, item limits and thecore.feed_modify_feed_rowevent apply to both formats.phpBB has no template event right after the forum description in
forumlist_body.html, so the links are appended toFORUM_DESCfor now.docs/events/forumlist_body_forum_desc_after.txtis the tracker request for that event.Testing
Claude ran these checks:
php -lon PHP 7.4 and 8.4, and the template accessibility check.Not covered on a live board: HTTP authentication, which phpBB only uses over HTTPS. A unit test runs phpBB's own HTTP authentication code for the RSS routes instead.
Screenshots were taken with the
screenshots.pyentry in phpbbmodders/phpbb-release-tools#35.Investigated and written by Claude on behalf of William Jacoby (bonelifer).