Repository navigation
Read the build from store/ when the old default path is empty - #15
Merged
Merged
Conversation
Boards set to the old default, ext/phpbbmodders/documentation/docs-build, keep it when a build was there at upgrade time. If that build is later moved to store/phpbbmodders_documentation without updating the setting, the extension now reads it from there instead of reporting no build. The ACP settings page says when this fallback is in use, and when the build in use is inside the extension's own directory, where the next extension update would delete it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boards set to the old default build path,
ext/phpbbmodders/documentation/docs-build, keep it after upgrading when a build was there at the time (migrationm7_store_docs_path). If that build is later moved tostore/phpbbmodders_documentationwithout updating the setting, the extension reported that no build was found.store/phpbbmodders_documentationhas one, the extension reads the build fromstore/. Any other path is used exactly as configured.Testing
Claude added tests for the fallback and both notices (132 tests), which pass in Docker on PHP 8.2 and 8.4. On a 3.3.19 test board, Claude reproduced a board still set to the old path with its build moved to
store/: the documentation loads and the fallback notice shows. With the build inside the extension, only the in-extension notice shows. The phpbb-release-tools feature checks pass.Investigated and written by Claude on behalf of William Jacoby (bonelifer).