Repository navigation
Give the missing-image test a language string - #11
Merged
Merged
Conversation
The unconfigured language mock returned null, so DOMDocument::createTextNode() raised a deprecation notice in every test run. The mock now returns the language key, and the test checks the notice text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_missing_image_preserves_its_alt_descriptionused an unconfiguredlanguagemock that returnsnull, soDOMDocument::createTextNode()raised a "Passing null to parameter Add optional split navigation links for docs vs. developer docs #1" deprecation notice on every test run.language::lang()always returns a string.Testing
Investigated and written by Claude on behalf of William Jacoby (bonelifer).