Skip to content

Run EPV through the organization's strict EPV workflow #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bonelifer merged 2 commits into from
Oct 19, 2026
Merged

Run EPV through the organization's strict EPV workflow #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6e8b8e
Run EPV through the organization's strict EPV workflow
bonelifer Oct 19, 2026
206147d
Use the EPV workflow's v1 tag
bonelifer Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/epv-allowed.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# EPV findings this extension keeps on purpose, checked by the epv job in
# .github/workflows/tests.yml. One finding per line as EPV prints it, without
# "on line N", with paths relative to the extension; give the reason above it.

# ext.php reads phpBB's own serialized migration dependency lists when it moves
# an old rmcgirr83/contactadmin install, with allowed_classes off, so no objects
# can be created.
Error: Using unserialize in /ext.php
29 changes: 10 additions & 19 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ env:
EXTNAME: phpbbmodders/contactadmin # Your extension vendor/package name
SNIFF: 1 # Run code sniffer on your code? 1 or 0
IMAGE_ICC: 1 # Run icc profile sniffer on your images? 1 or 0
EPV: 1 # Run EPV (Extension Pre Validator) on your code? 1 or 0
EXECUTABLE_FILES: 1 # Run check for executable files? 1 or 0

on:
Expand All @@ -18,7 +17,7 @@ on:
- develop

jobs:
# START Basic Checks Job (EPV, code sniffer, images check, etc.)
# START Basic Checks Job (code sniffer, images check, etc.)
basic-checks:
runs-on: ubuntu-latest
strategy:
Expand All @@ -30,17 +29,11 @@ jobs:
db: 'none'
NOTESTS: 1
phpbb: '3.3.x'
composer: 'composer'
epv: 'dev-master'
# phpBB 4.0 (the master branch) with its minimum PHP. EPV's
# phpBB 4.0 branch, installed with phpBB's own Composer, as
# phpbb-extensions/test-framework does for phpBB 4.0
# phpBB 4.0 (the master branch) with its minimum PHP
- php: '8.2'
db: 'none'
NOTESTS: 1
phpbb: 'master'
composer: 'php ../composer.phar'
epv: 'dev-epv-phpbb4'

name: PHP ${{ matrix.php }} - ${{ matrix.db }}${{ matrix.phpbb == 'master' && ' - phpBB 4.0' || '' }}

Expand Down Expand Up @@ -75,11 +68,6 @@ jobs:
run: .github/setup-phpbb.sh $DB $PHP_VERSION $NOTESTS
working-directory: ./phpBB3

- name: Setup EPV
if: ${{ env.EPV != 0 }}
run: ${{ matrix.composer }} require phpbb/epv:${{ matrix.epv }} --dev --no-interaction --ignore-platform-reqs
working-directory: ./phpBB3/phpBB

- name: Run code sniffer
if: ${{ env.SNIFF != 0 }}
env:
Expand All @@ -96,9 +84,12 @@ jobs:
if: ${{ env.EXECUTABLE_FILES != 0 }}
run: .github/ext-check-executable-files.sh ./ $EXTNAME
working-directory: ./phpBB3

- name: Run EPV
if: ${{ env.EPV != 0 }}
run: phpBB/vendor/bin/EPV.php run --dir="phpBB/ext/$EXTNAME/"
working-directory: ./phpBB3
# END Basic Checks Job

# EPV (Extension Pre Validator), failing on any Fatal or Error finding not
# listed in .github/epv-allowed.txt
epv:
uses: phpbbmodders/.github/.github/workflows/epv.yml@v1
with:
EXTNAME: phpbbmodders/contactadmin
PHPBB_BRANCHES: '["3.3.x", "master"]'
Loading