Guard against null token after trailing backslash in text role#1333
Open
lacatoire wants to merge 1 commit intophpDocumentor:mainfrom
Open
Guard against null token after trailing backslash in text role#1333lacatoire wants to merge 1 commit intophpDocumentor:mainfrom
lacatoire wants to merge 1 commit intophpDocumentor:mainfrom
Conversation
When a text role candidate contains a backslash followed by end of input, moveNext() leaves the lexer token as null and the next read on ->value triggered a 'Attempt to read property "value" on null' warning. Bail out of the loop in that case, matching the other terminal branches of the switch. The rule then falls through to rollback() and returns null, so the input is simply not interpreted as a text role. Fixes phpDocumentor/phpDocumentor#4082
lacatoire
force-pushed
the
fix/textrole-null-backslash
branch
from
011b1f4 to
d8c00d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a text role candidate is followed by a trailing backslash at the end of the stream (or end of the block),
moveNext()leaves$lexer->tokenas null and the next read on->valuetriggers aWarning: Attempt to read property "value" on null.Bail out of the loop in that case, matching what the other terminal branches already do. The rule then falls through to
rollback()and returns null, so the input is simply not interpreted as a text role.Fixes phpDocumentor/phpDocumentor#4082