Repository navigation
[WIP] PHP 8.6 release page - #2030
saundefined wants to merge 7 commits into
Conversation
|
📊 Regression report for commit 284f24a is at https://web-php-regression-report-pr-2030.preview.thephp.foundation |
|
🚀 Preview for commit 284f24a is available at https://web-php-pr-2030.preview.thephp.foundation |
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
| new FeatureComparison( | ||
| id: 'duration-class', | ||
| title: message('duration_title', $lang), | ||
| description: message('duration_description', $lang), | ||
| links: [ | ||
| 'RFC|https://wiki.php.net/rfc/duration_class', | ||
| ], | ||
| before: <<<'PHP' | ||
| // TODO | ||
| PHP, | ||
| after: <<<'PHP' | ||
| // TODO | ||
| PHP, | ||
| ), |
There was a problem hiding this comment.
For Duration perhaps a custom wrapper around time_nanosleep()? The class nicely maps directly onto the parameters of time_nanosleep().
And then perhaps showcase some of the mathematical operations, e.g. the delay example from the RFC: https://wiki.php.net/rfc/duration_class#examples
| 'documentation' => 'Doc', | ||
| 'released' => 'Released Nov 19, 2026', | ||
| 'key_features' => 'Key Features in PHP 8.6', | ||
| 'key_features_description' => '<p><strong>Faster</strong>, <strong>cleaner</strong>, and <strong>built for developers</strong>.</p>', |
There was a problem hiding this comment.
Can we avoid putting the <p> tags in the message contents, if the entire message is a single paragraph? Just wrap the actual usage in the tags, to make translating easier
| 'key_features' => 'Key Features in PHP 8.6', | ||
| 'key_features_description' => '<p><strong>Faster</strong>, <strong>cleaner</strong>, and <strong>built for developers</strong>.</p>', | ||
|
|
||
| 'features_pfa_description' => '<p>Allows functions to be called with only a subset of the required parameters, deferring the passing of the remaining ones to a later time.</p>', |
There was a problem hiding this comment.
this description is wrong - functions are not called with a subset of the required parameters, rather a subset of parameters is specified and the call is delayed until the remaining ones are provided
| 'features_sort_direction_description' => '<p>Represents a sort directions.</p>', | ||
|
|
||
| 'pfa_title' => 'Partial Function Application', | ||
| 'pfa_description' => 'Allows functions to be called with only a subset of the required parameters, deferring the passing of the remaining ones to a later time.', |
There was a problem hiding this comment.
any expected difference between this and features_pfa_description? Same with some of the other description messages - if they are expected to be the same, just reuse the original one?
Not repeating my comments on the various features_* and other messages
There was a problem hiding this comment.
I’ve separated these into two different language keys, because the features_* descriptions might be simplified or condensed, whereas the main descriptions might require more detail.
If the wording ends up being the same, we can always merge them.
| } | ||
|
|
||
| \site_header("PHP 8.6 Release Announcement", [ | ||
| 'current' => 'php85', |
There was a problem hiding this comment.
are these meant to say 8.5 for current and for the css ?
There was a problem hiding this comment.
css — includes the necessary files,
current — adds a css class to the current page
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
Rendering on mobile is broken:
For PHP 8.5:
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com> Co-authored-by: Daniel Scherzer <daniel.e.scherzer@gmail.com>
Co-authored-by: Theodore Brown <theodorejb@outlook.com>
@TimWolla should be fixed |
|
The icons currently in the Key Features section are confusing, since they don't seem to have anything to do with the features (apparently they were just copied from the 8.5 release page?). |
|
The Partial Function Application section shows "PHP 8.5 and older" for the left-hand pipe operator example, but it should just be PHP 8.5, since the pipe operator wasn't available on older versions. |
URL: https://web-php-pr-2030.preview.thephp.foundation/releases/8.6/en.php