Skip to content

790: disable mirrors when PIE overrides download URLs #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgrim merged 1 commit into from
Nov 3, 2026
Merged

790: disable mirrors when PIE overrides download URLs #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ComposerIntegration/Listeners/OverrideDownloadUrlInstallListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Composer\Installer\InstallerEvents;
use Composer\IO\IOInterface;
use Composer\Package\CompletePackageInterface;
use Composer\Package\Package as ComposerPackage;
use Composer\Util\HttpDownloader;
use Php\Pie\ComposerIntegration\PieComposerRequest;
use Php\Pie\ComposerIntegration\PieOperation;
Expand Down Expand Up @@ -155,6 +156,10 @@ function (OperationInterface $operation): void {

$this->composerRequest->pieOutput->write('Found prebuilt archive: ' . $matchedReleaseAsset->url);
$composerPackage->setDistUrl($matchedReleaseAsset->url);
$composerPackage->setDistMirrors(null);
if ($composerPackage instanceof ComposerPackage) {
$composerPackage->setDistSha1Checksum(null);
}

$composerPackage->setTransportOptions(array_merge_recursive(
$composerPackage->getTransportOptions(),
Expand Down
133 changes: 133 additions & 0 deletions test/unit/ComposerIntegration/Listeners/OverrideDownloadUrlInstallListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,139 @@ public function testDistUrlIsUpdatedForPrePackagedTgzSource(): void
self::assertSame('tar', $composerPackage->getDistType());
}

public function testPreferredDistMirrorDoesNotReplaceReleaseAssetUrl(): void
{
$composerPackage = new CompletePackage('foo/bar', '1.2.3.0', '1.2.3');
$composerPackage->setDistType('zip');
$composerPackage->setDistUrl('https://example.com/git-archive-zip-url');
$composerPackage->setDistReference('abc123');
$composerPackage->setDistMirrors([
[
'url' => 'https://mirror.example.com/dists/%package%/%version%/r%reference%.%type%',
'preferred' => true,
],
]);
$composerPackage->setPhpExt([
'extension-name' => 'foobar',
'download-url-method' => 'pre-packaged-source',
]);

$installerEvent = new InstallerEvent(
InstallerEvents::PRE_OPERATIONS_EXEC,
$this->composer,
$this->io,
false,
true,
new Transaction([], [$composerPackage]),
);

$packageReleaseAssets = $this->createMock(PackageReleaseAssets::class);
$packageReleaseAssets
->expects(self::once())
->method('findMatchingReleaseAsset')
->willReturn(new MatchedReleaseAsset(
'https://api.github.com/repos/foo/bar/releases/assets/22222',
'php_foobar-1.2.3-src.tgz',
));

$this->container
->method('get')
->with(PackageReleaseAssets::class)
->willReturn($packageReleaseAssets);

(new OverrideDownloadUrlInstallListener(
$this->composer,
$this->io,
$this->container,
new PieComposerRequest(
$this->createMock(IOInterface::class),
new TargetPlatform(
OperatingSystem::NonWindows,
OperatingSystemFamily::Linux,
PhpBinaryPath::fromCurrentProcess(),
Architecture::x86_64,
ThreadSafetyMode::NonThreadSafe,
1,
WindowsCompiler::VC15,
null,
),
[new RequestedPackageAndVersion('foo/bar', '^1.1')],
PieOperation::Install,
[],
false,
),
))($installerEvent);

self::assertSame(
['https://api.github.com/repos/foo/bar/releases/assets/22222'],
$composerPackage->getDistUrls(),
);
}

public function testRepositoryShasumIsNotUsedForReleaseAsset(): void
{
$composerPackage = new CompletePackage('foo/bar', '1.2.3.0', '1.2.3');
$composerPackage->setDistType('zip');
$composerPackage->setDistUrl('https://example.com/git-archive-zip-url');
$composerPackage->setDistSha1Checksum('da39a3ee5e6b4b0d3255bfef95601890afd80709');
$composerPackage->setPhpExt([
'extension-name' => 'foobar',
'download-url-method' => 'pre-packaged-source',
]);

$installerEvent = new InstallerEvent(
InstallerEvents::PRE_OPERATIONS_EXEC,
$this->composer,
$this->io,
false,
true,
new Transaction([], [$composerPackage]),
);

$packageReleaseAssets = $this->createMock(PackageReleaseAssets::class);
$packageReleaseAssets
->expects(self::once())
->method('findMatchingReleaseAsset')
->willReturn(new MatchedReleaseAsset(
'https://api.github.com/repos/foo/bar/releases/assets/22222',
'php_foobar-1.2.3-src.tgz',
));

$this->container
->method('get')
->with(PackageReleaseAssets::class)
->willReturn($packageReleaseAssets);

(new OverrideDownloadUrlInstallListener(
$this->composer,
$this->io,
$this->container,
new PieComposerRequest(
$this->createMock(IOInterface::class),
new TargetPlatform(
OperatingSystem::NonWindows,
OperatingSystemFamily::Linux,
PhpBinaryPath::fromCurrentProcess(),
Architecture::x86_64,
ThreadSafetyMode::NonThreadSafe,
1,
WindowsCompiler::VC15,
null,
),
[new RequestedPackageAndVersion('foo/bar', '^1.1')],
PieOperation::Install,
[],
false,
),
))($installerEvent);

self::assertSame(
'https://api.github.com/repos/foo/bar/releases/assets/22222',
$composerPackage->getDistUrl(),
);
self::assertNull($composerPackage->getDistSha1Checksum());
}

public function testDistUrlIsUpdatedForPrePackagedTgzBinaryWhenBinaryIsFound(): void
{
$composerPackage = new CompletePackage('foo/bar', '1.2.3.0', '1.2.3');
Expand Down
Loading