Skip to content

Feature: Implement Prototype.js DOM traversal methods (GH-23575) #23613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prateekbhujel wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature: Implement Prototype.js DOM traversal methods (GH-23575) #23613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c42540f
Fix GH-23575: Add Prototype.js-like DOM Traversal to Dom\Element
prateekbhujel Sep 8, 2026
1356bc3
Fix uninitialized 'id' compilation error in Dom\Element prototype tra…
prateekbhujel Sep 8, 2026
a7c08fc
Fix class name casing in traversal_prototype test expectation
prateekbhujel Sep 8, 2026
5bc2e77
Update generated php_dom_decl.h stub hash
prateekbhujel Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 114 additions & 0 deletions ext/dom/element.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2013,6 +2013,120 @@ PHP_METHOD(Dom_Element, matches)
dom_element_matches(thisp, intern, return_value, selectors_str);
}


PHP_METHOD(Dom_Element, up)
{
zend_string *selectors_str = NULL;
zend_long index = 0;

ZEND_PARSE_PARAMETERS_START(0, 2)
Z_PARAM_OPTIONAL
Z_PARAM_STR_OR_NULL(selectors_str)
Z_PARAM_LONG(index)
ZEND_PARSE_PARAMETERS_END();

if (index < 0) {
zend_argument_value_error(2, "must be greater than or equal to 0");
RETURN_THROWS();
}

xmlNodePtr thisp;
dom_object *intern;
zval *id;
DOM_GET_THIS_OBJ(thisp, id, xmlNodePtr, intern);

dom_element_up(thisp, intern, return_value, selectors_str, index);
}

PHP_METHOD(Dom_Element, down)
{
zend_string *selectors_str = NULL;
zend_long index = 0;

ZEND_PARSE_PARAMETERS_START(0, 2)
Z_PARAM_OPTIONAL
Z_PARAM_STR_OR_NULL(selectors_str)
Z_PARAM_LONG(index)
ZEND_PARSE_PARAMETERS_END();

if (index < 0) {
zend_argument_value_error(2, "must be greater than or equal to 0");
RETURN_THROWS();
}

xmlNodePtr thisp;
dom_object *intern;
zval *id;
DOM_GET_THIS_OBJ(thisp, id, xmlNodePtr, intern);

dom_element_down(thisp, intern, return_value, selectors_str, index);
}

PHP_METHOD(Dom_Element, next)
{
zend_string *selectors_str = NULL;
zend_long index = 0;

ZEND_PARSE_PARAMETERS_START(0, 2)
Z_PARAM_OPTIONAL
Z_PARAM_STR_OR_NULL(selectors_str)
Z_PARAM_LONG(index)
ZEND_PARSE_PARAMETERS_END();

if (index < 0) {
zend_argument_value_error(2, "must be greater than or equal to 0");
RETURN_THROWS();
}

xmlNodePtr thisp;
dom_object *intern;
zval *id;
DOM_GET_THIS_OBJ(thisp, id, xmlNodePtr, intern);

dom_element_next(thisp, intern, return_value, selectors_str, index);
}

PHP_METHOD(Dom_Element, previous)
{
zend_string *selectors_str = NULL;
zend_long index = 0;

ZEND_PARSE_PARAMETERS_START(0, 2)
Z_PARAM_OPTIONAL
Z_PARAM_STR_OR_NULL(selectors_str)
Z_PARAM_LONG(index)
ZEND_PARSE_PARAMETERS_END();

if (index < 0) {
zend_argument_value_error(2, "must be greater than or equal to 0");
RETURN_THROWS();
}

xmlNodePtr thisp;
dom_object *intern;
zval *id;
DOM_GET_THIS_OBJ(thisp, id, xmlNodePtr, intern);

dom_element_previous(thisp, intern, return_value, selectors_str, index);
}

PHP_METHOD(Dom_Element, siblings)
{
zend_string *selectors_str = NULL;

ZEND_PARSE_PARAMETERS_START(0, 1)
Z_PARAM_OPTIONAL
Z_PARAM_STR_OR_NULL(selectors_str)
ZEND_PARSE_PARAMETERS_END();

xmlNodePtr thisp;
dom_object *intern;
zval *id;
DOM_GET_THIS_OBJ(thisp, id, xmlNodePtr, intern);

dom_element_siblings(thisp, intern, return_value, selectors_str);
}

PHP_METHOD(Dom_Element, closest)
{
zend_string *selectors_str;
Expand Down
Loading
Loading