Skip to content

perf: avoid float formatting in phpdbg's vasprintf fallback #23605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henderkes wants to merge 1 commit into from
+4 −0
Closed

perf: avoid float formatting in phpdbg's vasprintf fallback #23605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sapi/phpdbg/phpdbg_out.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ int phpdbg_process_print(int fd, int type, const char *msg, int msglen) {
if (msg) {
struct timeval tp;
if (gettimeofday(&tp, NULL) == SUCCESS) {
#ifdef HAVE_VASPRINTF
msgoutlen = phpdbg_asprintf(&msgout, "[%ld %.8F]: %.*s\n", tp.tv_sec, tp.tv_usec / 1000000., msglen, msg);
#else
msgoutlen = phpdbg_asprintf(&msgout, "[%ld 0.%06ld00]: %.*s\n", tp.tv_sec, (long) tp.tv_usec, msglen, msg);
#endif
} else {
msgoutlen = FAILURE;
}
Expand Down
Loading