Handle error strerror values in bless#22205
Draft
NattyNarwhal wants to merge 1 commit into
Draft
Conversation
One annoyance with bless is its tendency to hardcode OS-specific errors in expect output, especially when the test was already making it to begin with, and bless instead hardcodes it again. Build a list of strerror values, scan the output for them, and replace them with '%s'. Perhaps this may be overzealous, but it does seem to work to keep bless output reasonable with less post-processing.
NattyNarwhal
force-pushed
the
bless-strerror
branch
from
d5a6d93 to
6dfce36
Compare
NattyNarwhal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One annoyance with bless is its tendency to hardcode OS-specific errors in expect output, especially when the test was already making it to begin with, and bless instead hardcodes it again.
Build a list of strerror values, scan the output for them, and replace them with '%s'. Perhaps this may be overzealous, but it does seem to work to keep bless output reasonable with less post-processing.