Skip to content

ext/xsl: handle xsltNewTransformContext allocation failure #21887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iliaal wants to merge 2 commits into
base: PHP-8.4
Choose a base branch
from
+9 −0
Open

ext/xsl: handle xsltNewTransformContext allocation failure #21887

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2caad39
ext/xsl: handle xsltNewTransformContext allocation failure
iliaal Apr 27, 2026
1156db9
ext/xsl: discard partially-constructed ns on xmlStrdup failure
iliaal Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ext/xsl/xsltprocessor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,12 @@ static void xsl_add_ns_def(xmlNodePtr node)
ns->type = XML_LOCAL_NAMESPACE;
ns->href = should_free ? attr_value : xmlStrdup(attr_value);
ns->prefix = attr->ns->prefix ? xmlStrdup(attr->name) : NULL;

if (UNEXPECTED(ns->href == NULL || (attr->ns->prefix != NULL && ns->prefix == NULL))) {
xmlFreeNs(ns);
return;
}

ns->next = node->nsDef;
node->nsDef = ns;
}
Expand Down Expand Up @@ -350,6 +356,9 @@ static xmlDocPtr php_xsl_apply_stylesheet(zval *id, xsl_object *intern, xsltStyl
php_libxml_increment_doc_ref(intern->doc, doc);

ctxt = xsltNewTransformContext(style, doc);
if (UNEXPECTED(ctxt == NULL)) {
goto out;
}
ctxt->_private = (void *) intern;

if (intern->parameter) {
Expand Down
Loading