Skip to content

Convert remaining zend_parse_parameters_none() to fast ZPP#21343

Open
alexandre-daubois wants to merge 1 commit intophp:masterfrom
alexandre-daubois:zpp-final-round
Open

Convert remaining zend_parse_parameters_none() to fast ZPP#21343
alexandre-daubois wants to merge 1 commit intophp:masterfrom
alexandre-daubois:zpp-final-round

Conversation

@alexandre-daubois
Copy link
Member

Final round. There are 2 remaining, but I'm not aware of a way to update them (because they goto or return NULL explicitly)

@alexandre-daubois alexandre-daubois changed the title Convert remaining zend_parse_parameters_none() to ZPP Convert remaining zend_parse_parameters_none() to fast ZPP Mar 4, 2026
@TimWolla
Copy link
Member

TimWolla commented Mar 4, 2026

There are 2 remaining, but I'm not aware of a way to update them (because they goto or return NULL explicitly)

Do you have a link for reference?

@alexandre-daubois
Copy link
Member Author

Of course, here they are:

php-src/ext/spl/spl_array.c

Lines 1227 to 1229 in 11a9574

if (zend_parse_parameters_none() == FAILURE) {
goto exit;
}

if (zend_parse_parameters_none() == FAILURE) {
return NULL;
}

@Girgias
Copy link
Member

Girgias commented Mar 5, 2026

Submitted #21349 for the one in spl_array.c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants