Fix GH-21336: undefined behavior in snmp setSecurity.#21337
Open
devnexen wants to merge 1 commit intophp:PHP-8.4from
Open
Fix GH-21336: undefined behavior in snmp setSecurity.#21337devnexen wants to merge 1 commit intophp:PHP-8.4from
devnexen wants to merge 1 commit intophp:PHP-8.4from
Conversation
Girgias
requested changes
Mar 5, 2026
Comment on lines
962
to
+967
| static bool netsnmp_session_set_auth_protocol(struct snmp_session *s, zend_string *prot) | ||
| { | ||
| if (!prot) { | ||
| zend_value_error("Authentication protocol can't be NULL"); | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
Considering these are static functions I'd rather use ZEND_ATTRIBUTE_NONNULL and check this on the call site as an error message indicating something cannot be a NULL pointer is useless from a PHP user PoV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.