Skip to content

Fix ip2long in AIX to treat IPs with leading zeros as invalid like LINUX #21296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reshmavk wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+11 −0
Open

Fix ip2long in AIX to treat IPs with leading zeros as invalid like LINUX #21296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ext/standard/basic_functions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,17 @@ PHP_FUNCTION(ip2long)
if (addr_len == 0 || inet_pton(AF_INET, addr, &ip) != 1) {
RETURN_FALSE;
}
#ifdef _AIX
/*
AIX accepts IP strings with excedentary 0 (192.168.042.42 will be treated as
192.168.42.42), while Linux don't.
Comment on lines +603 to +604
Copy link
Contributor

@mvorisek mvorisek Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If such function is expected, it should be tested.

For consistency, we convert back the IP to a string and check if it is equal to
the original string. If not, the IP should be considered invalid.
*/
if (strcmp(addr, inet_ntoa(ip)) != 0) {
Copy link
Member

@devnexen devnexen Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question: is inet_ntop available on AIX ?

Copy link
Author

@reshmavk reshmavk Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, inet_ntop is available

Copy link
Member

@devnexen devnexen Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is preferable over inet_ntoa. I know it s easier, but it is also deprecated.

Copy link
Author

@reshmavk reshmavk Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the code to use inet_ntop instead of inet_ntoa.

RETURN_FALSE;
}
#endif
RETURN_LONG(ntohl(ip.s_addr));
}
/* }}} */
Expand Down
Loading